Apply non-semantic changes from #1538#1555
Merged
Nigel-Ecma merged 1 commit intodraft-v8from Jan 29, 2026
Merged
Conversation
The hope is that this can reduce the diff in #1538, making it easier to review.
jskeet
commented
Jan 28, 2026
Contributor
Author
|
@Nigel-Ecma The hope is that after this is merged, you can rebase your PR and there'll be a smaller diff. Two bits where you'll have some work to do:
|
BillWagner
approved these changes
Jan 28, 2026
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM. Once Nigel has a look, let's see how well this works.
Nigel-Ecma
approved these changes
Jan 29, 2026
Contributor
Nigel-Ecma
left a comment
Nigel-Ecma
left a comment
There was a problem hiding this comment.
Well each red/green pair looks like it has the expected changes, so I guess we try Jon’s idea out…
Contributor
|
@BillWagner – pushed Merge, but I’ll leave Delete branch to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hope is that this can reduce the diff in #1538, making it easier to review.