Open
Conversation
Draft of some process tweaks based on our experience in C# 8.
RexJaeschke
reviewed
Feb 4, 2026
Co-authored-by: Rex Jaeschke <rex@RexJaeschke.com>
RexJaeschke
reviewed
Feb 4, 2026
Co-authored-by: Rex Jaeschke <rex@RexJaeschke.com>
RexJaeschke
approved these changes
Feb 4, 2026
jskeet
added
the
meeting: discuss
jskeet
reviewed
Feb 11, 2026
|
|
||
| A committee member takes ownership of the draft PR and self-assigns it. The *assignee* reviews and modifies the initial PR. At the assignee's discretion, they can tag other members for help or opinion on the overall direction of the PR. | ||
|
|
||
| Once the assignee has a good first draft, it's ready for the [First Reading](#first-reading). As part of getting ready for the first reading, the assignee should provide a summary of the PR to guide reviewers. This should cover: |
Contributor
There was a problem hiding this comment.
Presumably if the assignee thinks the direction is actually wrong, and wants overally committee feedback, that's fine to bring to a first reading too?
| - Direction approved, move on to final edits and [Second reading](#second-reading). | ||
| - Direction or content needs major work. Bring a revised PR back for a new first reading. (Task list comes from meeting review comments.) | ||
|
|
||
| The goal for this review is to minimize major rewrites to large new issues discovered later in the process. On rare occasion that a feature PR is quite small, the first reading and second reading can be combined. |
Contributor
There was a problem hiding this comment.
Suggested change
| The goal for this review is to minimize major rewrites to large new issues discovered later in the process. On rare occasion that a feature PR is quite small, the first reading and second reading can be combined. | |
| The goal for this review is to minimize major rewrites to large new issues discovered later in the process. On the rare occasion that a feature PR is quite small, the first reading and second reading can be combined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a couple email discussions with Jon regarding what we can learn from C# 8 and how we can improve.