-
Notifications
You must be signed in to change notification settings - Fork 401
Refactor build pipeline to separate test jobs #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
31f61e6
Refactor build pipeline to separate test jobs
hoyosjs b5ff03d
Split CI build/test outputs and move tests to net10
hoyosjs 3b05a95
Keep tests on net8
hoyosjs 7895776
Skip debuggee/runtime rebuild on test legs; bundle dotnet-test
hoyosjs a5ed156
Install runtimes fresh on test legs instead of bundling dotnet-test
hoyosjs 17e2280
Move tests back to net10 and drop tools.runtimes net8 node
hoyosjs 2409ca2
Install x86 net10 runtime for x86 test host
hoyosjs 6fce10d
Publish obj artifacts and use test.cmd/test.sh for test-only legs
hoyosjs be8763f
Drop Traversal Test->Build dependency on prebuilt test legs
hoyosjs fc39af3
Reduce verbose MSBuild logging in test/debuggee builds
hoyosjs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <Project> | ||
|
|
||
| <!-- | ||
| Imported via $(CustomAfterTraversalTargets) after the Microsoft.Build.Traversal SDK targets, | ||
| so it can override properties the SDK sets unconditionally. | ||
|
|
||
| The Traversal SDK hardcodes <TestDependsOn>Build</TestDependsOn>, which makes every traversal's | ||
| "Test" target build its entire subgraph (product + tests + their project references) before | ||
| running tests, regardless of whether -build was passed. On the test-only CI legs the product and | ||
| test binaries are downloaded as prebuilt TestArtifacts, so rebuilding them is pure waste - and | ||
| because pipeline artifact downloads do not preserve file timestamps, the up-to-date check fails | ||
| and it becomes a full recompile. | ||
|
|
||
| Drop the Build dependency when the managed build was skipped ($(SkipTestArtifactsBuild) is set by | ||
| build.ps1 / build.sh for -skipmanaged). The traversal "Test" target still invokes "Test" on each | ||
| referenced project, so tests run directly against the downloaded binaries with no build. | ||
| --> | ||
| <PropertyGroup Condition="'$(SkipTestArtifactsBuild)' == 'true'"> | ||
| <TestDependsOn></TestDependsOn> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.