Add ProcessInfo3 large-payload negative test#5918
Open
tommcdon wants to merge 1 commit into
Open
Conversation
Adds a GetProcessInfo test that drives the target's command line long enough that the serialized ProcessInfo3 payload reaches the top of the uint16_t message-size range, and verifies the runtime responds with a well-formed server error while staying alive. The test calibrates against a live target so it computes the required command-line length across platforms and runtime builds, and runs only against .NET 11. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new negative test in the NETCore.Client test suite to validate that .NET 11+ runtimes gracefully reject oversized ProcessInfo3 responses (near the uint16_t IPC message-size limit) without crashing the target process.
Changes:
- Introduces a calibration step to compute per-platform/per-runtime payload sizing based on live
GetProcessInfooutput. - Sweeps a range of command-line lengths intended to cross the IPC payload overflow boundary and asserts the runtime returns a well-formed server error and remains alive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+61
| [SkippableTheory, MemberData(nameof(Configurations))] | ||
| public Task OversizeProcessInfoPayloadIsRejectedTest(TestConfiguration config) | ||
| { | ||
| return OversizeProcessInfoPayloadIsRejectedTestCore(config, useAsync: true); | ||
| } |
Comment on lines
+160
to
+162
| // The regression: the target must never crash, whatever the command-line length. | ||
| Assert.False(Process.GetProcessById(runner.Pid).HasExited, $"Target process crashed for argument length {argLength}."); | ||
| } |
steveisok
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GetProcessInfo test that drives the target's command line long enough that the serialized ProcessInfo3 payload reaches the top of the uint16_t message-size range, and verifies the runtime responds with a well-formed server error while staying alive. The test calibrates against a live target so it computes the required command-line length across platforms and runtime builds, and runs only against .NET 11.