Update test asset baselines for ClrMD ELF ImageSize fix#5925
Draft
max-charlamb wants to merge 3 commits into
Draft
Update test asset baselines for ClrMD ELF ImageSize fix#5925max-charlamb wants to merge 3 commits into
max-charlamb wants to merge 3 commits into
Conversation
…60708.1 On relative base path root Microsoft.Diagnostics.Runtime , Microsoft.Diagnostics.Runtime.Utilities From Version 4.1.735601 -> To Version 4.1.735801
ClrMD 4.1.735801 (microsoft/clrmd#1495, commit 6ac1d967e) fixes ELF core dump ImageSize to include the PT_LOAD anonymous (.bss/NOBITS) tail. This increases the reported ImageSize for native ELF modules, breaking the Linux subresults of DebugServicesTests.ModuleTests against the old testassets baselines (Windows PE modules are unaffected). Regenerated the Linux x64/arm64 testassets baseline XMLs (ImageSize only) and bumped TestAssetsVersion to 1.0.736301 (all four 6.0 packages share this pin). Verified locally: ModuleTests goes from Failed 6/Passed 3 to Passed 9/Failed 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the test-asset regeneration helpers so they work against the current repo layout and published baseline version: - writexml.cmd/.sh: point at the net8.0 dotnet-dump and DebugServices unit-test extension outputs (were net6.0 / netcoreapp3.1/publish) and drop the stale --fx-version 6.0.8. - rebuild/rewritexml.cmd + rebuild/*.nuspec: bump the source content version 1.0.257801 -> 1.0.351101 (the currently published baseline that regeneration reads from). Tooling-only; not consumed by CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DebugServicesTests.ModuleTestsfails on all Linux dumps (x64 + arm64) after the ClrMD dependency bump, e.g.:The failing member is
IModule.ImageSize, and only for native ELF modules (Windows PE modules are unaffected, so Windows subresults pass).Root cause
ClrMD
4.1.735601 -> 4.1.735801includes microsoft/clrmd#1495 (commit6ac1d967e, "Fix ELF core dump ImageSize to include PT_LOAD anonymous tail"). For ELF modules whose finalPT_LOADsegment hasMemSiz > FileSiz(a.bss/NOBITS zero-fill tail), the old NT_FILE-derived size under-reported the module footprint. The new, largerImageSizeis correct — it now includes the loader-mapped anonymous tail. This is expected baseline drift from a deliberate ClrMD fix, not a diagnostics regression.Fix
4.1.735801bump (the change that requires new baselines).testassetsbaseline XMLs (ImageSizevalues only) and bumpedTestAssetsVersion1.0.351101 -> 1.0.736301. All four 6.0 packages share this pin, so the two Windows packages are republished at the new version with unchanged content.Verification
Locally overlaying the regenerated baselines,
ModuleTestsgoes from Failed 6 / Passed 3 to Passed 9 / Failed 0. Each corrected value was independently confirmed against the dump''s actual ELFPT_LOADprogram headers.The regenerated
testassets.*packages must be published to thedotnet-diagnostics-testsfeed at1.0.736301before CI can pass (restore will otherwise fail to find the version). Packages were produced with the repo''s owneng/testassets/rebuild/pack.csprojtooling and are ready to push:TestAssets.Linux.x64.6.0.1.0.736301.nupkg(baselines updated)TestAssets.Linux.arm64.6.0.1.0.736301.nupkg(baselines updated)TestAssets.Windows.x64.6.0.1.0.736301.nupkg(content unchanged)TestAssets.Windows.x86.6.0.1.0.736301.nupkg(content unchanged)Draft until the packages are live.