Separate Registry Endpoints from Authentication in PublishConfig #1945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1914.
In draft mode because I haven't ran it through a pipeline to validate yet.
Problem
The current
PublishConfigurationtightly couples registry endpoints with authentication details. EachRegistryConfigurationembeds its ownServiceConnection,ResourceGroup, andSubscription, making it difficult to:Changes
Refactored
PublishConfigurationto separate concerns:New types:
RegistryEndpoint- Holds only the registry server addressRegistryAuthentication- HoldsServiceConnection+ ACR metadata (ResourceGroup,Subscription)New schema:
{ "PublishConfiguration": { "BuildRegistry": { "Server": "mybuildregistry.azurecr.io" }, "PublishRegistry": { "Server": "mypublishregistry.azurecr.io" }, "RegistryAuthentication": { "mybuildregistry.azurecr.io": { "ServiceConnection": { "Name": "...", "Id": "...", "TenantId": "...", "ClientId": "..." }, "ResourceGroup": "<guid>", "Subscription": "<guid>" } } } }Multiple registries can now share authentication by referencing the same key in
RegistryAuthentication.Files changed:
RegistryEndpoint.cs,RegistryAuthentication.csRegistryConfiguration.csFindRegistryAuthentication()PublishConfigurationBindingTests.csto validate config binding from json.Breaking change: JSON configuration schema has changed.