-
Notifications
You must be signed in to change notification settings - Fork 60
Add Renovate pipeline #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Renovate pipeline #1946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Renovate pipeline infrastructure to the dotnet/docker-tools repository for automated dependency updates. The implementation includes a reusable job template, configuration files, and a scheduled pipeline that will run nightly at 3 AM UTC.
Changes:
- Adds Renovate tracking comment to
src/Dockerfile.linuxfor ORAS version monitoring - Creates Renovate configuration with custom regex manager for Dockerfile ARG/ENV variables
- Implements reusable Azure Pipeline job template for running Renovate
- Sets up nightly scheduled pipeline with dry-run and force-recreate options
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Dockerfile.linux |
Adds Renovate tracking comment for ORAS_VERSION ARG to enable automated version updates |
eng/renovate.json |
Configures Renovate with custom regex manager and dockerfileVersions preset |
eng/renovate.env |
Defines environment variables for Renovate bot configuration including PR templates and author settings |
eng/pipelines/templates/jobs/renovate.yml |
Implements reusable job template that validates config, runs Renovate in Docker, and publishes logs |
eng/pipelines/renovate.yml |
Defines scheduled pipeline that runs nightly against dotnet/dotnet-docker repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| - template: /eng/docker-tools/templates/variables/sdl-pool.yml@self | ||
|
|
||
| extends: | ||
| template: /eng/docker-tools/templates/1es-official.yml@self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Use 1es.yml instead of 1es-official.yml (#1892)
| # GitHub repository to run Renovate against, in the format 'owner/repo'. | ||
| - name: gitHubRepo | ||
| type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Clarify any restrictions on this parameter in the comment. Will it work against any repo? Or will it only work on the repo that is running this pipeline?
| - script: mkdir -p $(logDirectory) && chmod 770 $(logDirectory) | ||
| displayName: Create log directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should $(Build.ArtifactStagingDirectory) be used for logs?
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: add linguist-language=JSON-with-Comments to the .gitattributes for this file so that the comments don't show up as errors.
| # docker build -t image-builder . | ||
| # docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v <local path to build>:/repo -w /repo image-builder <image-build args> | ||
|
|
||
| # renovate: datasource=github-releases depName=oras-project/oras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Where is the documentation for this format? I would like to read more about it. It's not clear to me how this links back to a regex version manager somewhere.
src/Dockerfile.linuxwith Renovate tracking comment for ORAS versionThe intent is for
eng/pipelines/templates/jobs/renovate.ymlandeng/renovate.envto be moved to Arcade once things have been evaluated in this repo first.Related: dotnet/arcade#15594