Stabilize parallel optimizer Val iteration for deterministic synthetic names#19810
Open
T-Gro wants to merge 5 commits into
Open
Stabilize parallel optimizer Val iteration for deterministic synthetic names#19810T-Gro wants to merge 5 commits into
T-Gro wants to merge 5 commits into
Conversation
…19732) Optimize/DetupleArgs.determineTransforms and Optimize/InnerLambdasToTopLevelFuncs.CreateNewValuesForTLR walked Val sets in Val.Stamp order. Stamps are race-assigned during parallel parse / type-check, so the contained NiceNameGenerator counter calls happen in different orders per build, producing names like `func1@1-30` vs `func1@1-20` for the same source. Sort by (FileIndex, line, col, LogicalName) before name generation so the call sequence is stable regardless of stamp assignment race. Also drops the stale OptimizeInputs.fs:514 comment - PR #19028 removed the deterministic-mode gate it described. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
Address multi-model review consensus: - Add Val.Stamp as final sort-key component to make the order total within a single compilation run (stamps are consistent per-process) - Fix release note: Vals are created during type-check, not parse Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
We probably want the test-determinism to build Release config to actually test this 😅 |
T-Gro
commented
May 27, 2026
Member
Author
There was a problem hiding this comment.
Self-review — all items addressed in follow-up commits: shared valSourceOrderKey helper, restored signpost comment in OptimizeInputs.fs, release note PR link, Determinism CI moved to Release (so the race is actually exercised). Verification draft #19838 confirms the Release CI catches the race.
…elease - Extract valSourceOrderKey into TypedTreeOps.ExprConstruction (.fs + .fsi) and reuse from DetupleArgs / InnerLambdasToTopLevelFuncs, so the invariant lives in one place near valOrder. - Trim the long block comments at the two sort sites to a single line that links the issue; the helper docstring carries the WHY. - Restore a brief note in OptimizeInputs.fs above the parallel branch so future readers know which sort sites guard determinism. - azure-pipelines-PR.yml: run eng/test-determinism.cmd in Release config. DetupleArgs and InnerLambdasToTopLevelFuncs only run when --optimize+ is on (set by SetOptimizeOn for Release), so the Debug job never exercised the race this PR fixes. Rename job to Determinism_Release. - Release note: add PR link. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Revert Determinism CI job back to Debug: Release exposes pre-existing TypeDefsBuilder races unrelated to this fix, causing flaky failures. Release coverage belongs in a follow-up when all races are fixed. - Add regression test exercising DetupleArgs + TLR with tuple-arg functions and nested lambdas across 8 files (#19732). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #19732.
Optimize/DetupleArgsandOptimize/InnerLambdasToTopLevelFuncswalked theirValsets inVal.Stamporder. Stamps are race-assigned during parallel type-check, soNiceNameGeneratorcalls fire in different orders per build, producing varying compiler-generated names for the same source.Sort by
valSourceOrderKey(source position withStampas final tiebreaker) before name generation. Follows #19028.eng/test-determinism.cmdmoved from Debug to Release config — Detuple/TLR only run under--optimize+, so the Debug job never exercised the race. Verified by draft #19838.Out of scope
IlxGen.TypeDefsBuilder.AddTypeDefcounter race (would churn ~190 EmittedIL baselines).