Add catalog signing for XML content files#19832
Draft
jesuszarate wants to merge 1 commit into
Draft
Conversation
Contributor
✅ No release notes required |
Non-PE files (XML docs, templates) cannot carry Authenticode signatures. This adds catalog signing infrastructure: 1. eng/Signing.props: Add FileExtensionSignInfo for .cat so Arcade signs the generated catalog with Microsoft400 2. eng/generate-catalog.ps1: Script to generate CDF and run makecat.exe 3. VisualFSharpDebug.csproj: GenerateCatalogFiles target that runs after VSIX assembly to produce a .cat covering xmlfile.xml Fixes VS signing scan violations for xmlfile.xml (VisualFSharpDebug VSIX). The fsharp.core_13.xml fix for the SDK Swix package is tracked separately (requires VS-repo catalog signing). Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/3008042
jesuszarate
force-pushed
the
sign-xml-catalog-files
branch
from
a6f22a1 to
ded207d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML files (IntelliSense docs, item templates) are non-PE and cannot carry Authenticode signatures directly. Adding FileExtensionSignInfo for .xml tells Arcade to generate a .cat catalog file covering them, signed with Microsoft400.
Fixes VS signing scan violations for fsharp.core_13.xml (F# SDK VSIX) and xmlfile.xml (VisualFSharpDebug VSIX).
The signing allow list (ExternalWhiteList.csv) in the VS repo will be zeroed out on June 8th. Files that are currently exempted will start failing the signing scan after that date.
Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/3008042