feat(Async+Task+ValueTask): consistent helper modules#19844
Open
bartelink wants to merge 3 commits into
Open
Conversation
Contributor
❗ Release notes required
|
bartelink
force-pushed
the
atvt
branch
2 times, most recently
from
5850539 to
7ad7946
Compare
5 tasks
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new camelCase helpers for Async, Task, and ValueTask in FSharp.Core, along with unit tests and surface area/release note updates.
Changes:
- Introduced
result,map,bind,ignore,catchWith,catch,emptyforAsync,Task,ValueTask(+Task.ofValueTask,ValueTask.ofTaskwhere available). - Added unit tests covering success/failure flows for the new helpers.
- Updated netstandard surface area baselines and release notes.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/TaskModuleFunctions.fs | New tests for Task/ValueTask camelCase helpers. |
| tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModuleFunctions.fs | New tests for Async camelCase helpers. |
| tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj | Includes the new test files in the test project. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard21.release.bsl | Surface area baseline updated for new APIs. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard21.debug.bsl | Surface area baseline updated for new APIs. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard20.release.bsl | Surface area baseline updated for new APIs. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard20.debug.bsl | Surface area baseline updated for new APIs. |
| src/FSharp.Core/tasks.fsi | Public signatures/docs for new Task/ValueTask modules. |
| src/FSharp.Core/tasks.fs | Implementation of new Task/ValueTask helpers. |
| src/FSharp.Core/async.fsi | Public signatures/docs for new Async camelCase helpers. |
| src/FSharp.Core/async.fs | Implementation of new Async camelCase helpers. |
| docs/release-notes/.FSharp.Core/11.0.100.md | Release notes entry for the new APIs. |
bartelink
commented
May 28, 2026
| result = (fun _ -> ()) | ||
| ) | ||
|
|
||
| [<CompilationRepresentation(CompilationRepresentationFlags.ModuleSuffix)>] |
Author
There was a problem hiding this comment.
should this be FSharpAsyncModule, pin AsyncModule or something else?
more important for Task and ValueTask of course
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds consistent helper modules for
Async,TaskandValueTask.Resolves fsharp/fslang-suggestions#1466
Checklist
Task.waithelper