Fix shouldBeParenthesizedInContext for Sequential in record fields (#17826)#19850
Open
T-Gro wants to merge 3 commits into
Open
Fix shouldBeParenthesizedInContext for Sequential in record fields (#17826)#19850T-Gro wants to merge 3 commits into
T-Gro wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…17826) Adds a match arm so SynExpr.Sequential inside SynExpr.Record or SynExpr.AnonRecd is reported as requiring its parentheses. Without the parens the semicolon is reparsed as a field separator, silently changing semantics or producing a parse error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17826
Summary
SynExpr.shouldBeParenthesizedInContext now returns rue for SynExpr.Sequential inside record (SynExpr.Record) and anonymous record (SynExpr.AnonRecd) field assignments. Without the parentheses, the semicolons are reparsed as field separators, silently changing semantics or producing parse errors.
Changes