Skip to content

Import: Don't walk non-F# assemblies when labelling trait constraint sources #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auduchinok wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Import: Don't walk non-F# assemblies when labelling trait constraint sources #20090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Compiler/Driver/CompilerImports.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,6 +2341,12 @@ and [<Sealed>] TcImports
let! ccuinfos = phase2s |> runMethod

if importsBase.IsSome then
let addConstraintSources (ia: ImportedAssembly) =
// Only an F# assembly can carry a trait constraint to label.
// Prevent force-reading of the whole assembly namespace tree for other assemblies.
if ia.FSharpViewOfMetadata.IsFSharp then
addConstraintSources ia

importsBase.Value.CcuTable.Values |> Seq.iter addConstraintSources
ccuTable.Values |> Seq.iter addConstraintSources

Expand Down
Loading