Skip to content

Remove web project configuration check#12785

Closed
Youssef1313 wants to merge 1 commit into
mainfrom
dev/ygerges/remove-hack
Closed

Remove web project configuration check#12785
Youssef1313 wants to merge 1 commit into
mainfrom
dev/ygerges/remove-hack

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@rainersigwald When we last discussed this check, you mentioned this was relevant for really old kinds of web projects. I'm guessing it might be safe to accept removing this hack? What do you think?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy support for old-style web projects that lack proper configuration mappings in solution files. The removed code provided a workaround for web projects missing specific configurations (typically Release) by checking if a solution configuration exists and allowing the build to proceed anyway.

  • Simplifies the WouldProjectBuild method by removing a web project-specific code path
  • Makes configuration handling consistent across all project types
  • Removes approximately 15 lines of conditional logic

@rainersigwald
Copy link
Copy Markdown
Member

We'd have to check with VS to see what the support policy on those projects is.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it has been open for more than 180 days with no recent activity.

If you believe this work is still relevant, please feel free to reopen or create a new pull request. Thank you for your contribution!

Note

🔒 Integrity filter blocked 46 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #13790 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13786 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13785 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13771 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13769 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13767 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13764 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13758 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13754 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13752 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13746 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13717 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13708 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13699 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13697 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13681 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • ... and 30 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Close Stale Pull Requests · ● 973.7K

@github-actions github-actions Bot closed this May 18, 2026
@Youssef1313 Youssef1313 deleted the dev/ygerges/remove-hack branch May 19, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants