Remove web project configuration check#12785
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy support for old-style web projects that lack proper configuration mappings in solution files. The removed code provided a workaround for web projects missing specific configurations (typically Release) by checking if a solution configuration exists and allowing the build to proceed anyway.
- Simplifies the
WouldProjectBuildmethod by removing a web project-specific code path - Makes configuration handling consistent across all project types
- Removes approximately 15 lines of conditional logic
|
We'd have to check with VS to see what the support policy on those projects is. |
|
This pull request has been automatically closed because it has been open for more than 180 days with no recent activity. If you believe this work is still relevant, please feel free to reopen or create a new pull request. Thank you for your contribution! Note 🔒 Integrity filter blocked 46 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | none
|
@rainersigwald When we last discussed this check, you mentioned this was relevant for really old kinds of web projects. I'm guessing it might be safe to accept removing this hack? What do you think?