Skip to content

Fix .NET Framework build: exclude TrimmingTests from compilation #130892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Open

Fix .NET Framework build: exclude TrimmingTests from compilation #130892

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f0845
Initial plan
Copilot Jul 16, 2026
e22540c
Fix .NET Framework build by excluding TrimmingTests from netfx compil…
Copilot Jul 16, 2026
393540b
Make TrimmingTests Compile Remove unconditional (not just .NETFramework)
Copilot Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ensions.Caching.Abstractions/tests/Microsoft.Extensions.Caching.Abstractions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
<EnableDefaultItems>true</EnableDefaultItems>
</PropertyGroup>

<ItemGroup>
<!-- TrimmingTests are standalone console apps built by their own .TrimmingTests.proj, not part of the xunit test assembly. -->
<Compile Remove="TrimmingTests\**" />
</ItemGroup>
Comment thread
svick marked this conversation as resolved.

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<ProjectReference Include="..\src\Microsoft.Extensions.Caching.Abstractions.csproj" />
<Compile Include="$(CoreLibSharedDir)System\Runtime\CompilerServices\IsExternalInit.cs" Link="Common\System\Runtime\CompilerServices\IsExternalInit.cs" />
Expand Down
Loading