[cDAC] Add the last two location types to DebugVarInfo cDAC representation#130909
Merged
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends cDAC’s DebugInfo variable-location support to represent and round-trip the remaining two VarLocType cases (VLT_FPSTK and VLT_FIXED_VA) by adding corresponding DebugVarLocKind values and DebugVarInfo fields, with updated docs and unit tests.
Changes:
- Add
FloatingPointStack/FixedVarArgtoDebugVarLocKindand carry their payloads viaDebugVarInfo. - Decode
VLT_FPSTKandVLT_FIXED_VAinto the newDebugVarInforepresentation and map them throughDacDbiImpl.ConvertToVarLoc. - Add unit tests covering the new mappings and decoding behavior; update the DebugInfo contract spec.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/tests/UnitTests/DacDbiImplTests.cs | Adds unit tests for FP stack + fixed vararg VarLoc decoding and VarLoc mapping. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.NativeCodeInfo.cs | Extends VarLoc conversion and debug-only equality validation to handle VLT_FPSTK / VLT_FIXED_VA. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/DebugInfo/DebugInfoHelpers.cs | Decodes VLT_FPSTK / VLT_FIXED_VA into new DebugVarInfo kinds instead of consuming-and-dropping. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IDebugInfo.cs | Adds new public enum values and new public DebugVarInfo fields to represent those location types. |
| docs/design/datacontracts/DebugInfo.md | Updates the DebugInfo contract spec to include the new enum members and fields. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 1
max-charlamb
approved these changes
Jul 16, 2026
Contributor
Author
|
/ba-g build analysis is stuck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during testing of floating point contexts.