Skip to content

[cDAC] Fix x86 context flags #130911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcj1 merged 4 commits into from
Jul 17, 2026
+13 −3
Merged

[cDAC] Fix x86 context flags #130911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf98692
E
rcj1 Jul 16, 2026
033e442
Update PlatformContextTests.cs
rcj1 Jul 16, 2026
3d7e522
Update X86Context.cs
rcj1 Jul 17, 2026
1e4d1cb
Fix comment formatting in X86Context.cs
rcj1 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rosoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/X86Context.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ public struct X86Context : IPlatformContext
[Flags]
public enum ContextFlagsValues : uint
{
CONTEXT_i386 = 0x00100000,
CONTEXT_i386 = 0x00010000,
CONTEXT_CONTROL = CONTEXT_i386 | 0x1,
CONTEXT_INTEGER = CONTEXT_i386 | 0x2,
CONTEXT_SEGMENTS = CONTEXT_i386 | 0x4,
CONTEXT_FLOATING_POINT = CONTEXT_i386 | 0x8,
CONTEXT_DEBUG_REGISTERS = CONTEXT_i386 | 0x10,
CONTEXT_EXTENDED_REGISTERS = CONTEXT_i386 | 0x20,
CONTEXT_FULL = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT,
CONTEXT_FULL = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_SEGMENTS,
CONTEXT_ALL = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_SEGMENTS | CONTEXT_FLOATING_POINT | CONTEXT_DEBUG_REGISTERS | CONTEXT_EXTENDED_REGISTERS,
CONTEXT_XSTATE = CONTEXT_i386 | 0x40,

Expand Down
12 changes: 11 additions & 1 deletion src/native/managed/cdac/tests/UnitTests/PlatformContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,16 @@ public void X86_OutOfRange_ReturnsFalse(int regNum)
Assert.False(ctx.TryReadRegister(regNum, out _));
}

[Fact]
public void X86_ContextFlags_MatchNativeContext()
{
var ctx = new X86Context();

Assert.Equal(0x00010001u, ctx.ContextControlFlags);
Assert.Equal(0x00010007u, ctx.FullContextFlags);
Assert.Equal(0x0001003fu, ctx.AllContextFlags);
}

[Theory]
[InlineData(0, 0x1234UL)] // R0
[InlineData(3, 0x2000UL)] // Sp
Expand Down Expand Up @@ -188,4 +198,4 @@ public void UnsetSingleStepFlag_IsNoOp_OnEmulatedSingleStepArches(IPlatformAgnos

Assert.Equal(before, ctx.GetBytes());
}
}
}
Loading