Skip to content

Make all entries in WASM tables SymbolDefinitions #130920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jtschuster wants to merge 4 commits into
base: main
Choose a base branch
from
+125 −101
Draft

Make all entries in WASM tables SymbolDefinitions #130920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4854223
Make entries in wasm tables "symbol definitions"
jtschuster Jul 9, 2026
82c4ebc
Rename wasm symbol index helper
jtschuster Jul 15, 2026
2b84bf9
"memoryBase" -> "imageBase"
jtschuster Jul 16, 2026
4c55e3d
Renames and doc comments
jtschuster Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/coreclr/tools/Common/Compiler/DependencyAnalysis/WasmWellKnownGlobalSymbolNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@ namespace ILCompiler.DependencyAnalysis
/// </summary>
public class WasmWellKnownGlobalSymbolNode(string symbolName) : ExternDataSymbolNode(new Utf8String(symbolName))
{
#if READYTORUN
public const string StackPointerName = "stackPointer";
public const string ImageBaseName = "imageBase";
public const string TableBaseName = "tableBase";
#else
public const string StackPointerName = "__stack_pointer";
public const string ImageBaseName = "__memory_base";
public const string TableBaseName = "__table_base";
#endif

public override int ClassCode => 0x79046cf9;

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/Compiler/ObjectWriter/ObjectWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ private protected virtual void EmitReferencedMethod(Utf8String symbolName) { }
/// the order of the symbols so any necessary sorting is done when the
/// symbol table is created.
/// </remarks>
protected internal void EmitSymbolDefinition(
protected internal virtual void EmitSymbolDefinition(
int sectionIndex,
Utf8String symbolName,
long offset = 0,
Expand Down
Loading
Loading