[release/10.0] Fix ComClassGenerator failure with generic types#130930
Open
github-actions[bot] wants to merge 2 commits into
Open
[release/10.0] Fix ComClassGenerator failure with generic types#130930github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
Replace < and > with { and } in hint names to avoid ArgumentException when generating source for generic COM classes. Add test case to validate the fix.
Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
added
the
Servicing-consider
JulieLeeMSFT
approved these changes
Jul 16, 2026
JulieLeeMSFT
added
Servicing-approved
elinor-fung
approved these changes
Jul 16, 2026
jtschuster
approved these changes
Jul 16, 2026
This was referenced Jul 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #122197 to release/10.0
/cc @AaronRobinsonMSFT @copilot
Customer Impact
This was originally found internally, but has now been discovered external in .NET 10. The customer is blocked moving from built-in COM scenarios to source generation and onto .NET 10.
Regression
Generics were never supported for COM and therefore wasn't considered.
Testing
A test was added.
Risk
Low. This enabling the parsing of generic names in the source generator.