Add MCP servers to dotnet-blazor plugin#703
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the dotnet-blazor plugin manifest to declare two MCP server dependencies (Microsoft Learn + Playwright) and adds the corresponding allowlist entries so the skill-validator’s external dependency checks don’t flag them.
Changes:
- Add
mcpServersentries toplugins/dotnet-blazor/plugin.json. - Allowlist the new MCP server declarations in
eng/allowed-external-deps.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plugins/dotnet-blazor/plugin.json | Declares two MCP servers for the dotnet-blazor plugin. |
| eng/allowed-external-deps.txt | Adds allowlist entries for the newly declared MCP servers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Skill Coverage Report
Uncovered:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
/evaluate |
Skill Validation Results
[1] (Isolated) Quality improved but weighted score is -8.2% due to: tokens (13230 → 45021), tool calls (0 → 3), time (17.2s → 22.2s) Model: claude-opus-4.6 | Judge: claude-opus-4.6 🔍 Full Results - additional metrics and failure investigation steps
▶ Sessions Visualisation -- interactive replay of all evaluation sessions |
|
✅ Evaluation passed for |
danroth27
left a comment
There was a problem hiding this comment.
I think we should move the MS Learn MCP server to the core dotnet plugin, but otherwise this looks fine to me.
|
👋 @javiercn — this PR has 2 unresolved review thread(s). When you're ready, please address the feedback and push an update; the triage bot will pick up the next state automatically. (Add the |
…ation (#723) * Initial plan * feat(dotnet-blazor): pin playwright MCP to 0.0.75 and add weekly update workflow * fix(update-playwright-mcp-version): use env vars in node scripts and descending sort --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
/evaluate |
Skill Validation Results❌ Skill validation errors
[1]
Model: claude-opus-4.6 | Judge: claude-opus-4.6 🔍 Full Results - additional metrics and failure investigation steps
|
Skill Validation Results
[1] (Plugin) Quality unchanged but weighted score is -3.7% due to: tokens (25703 → 43968) Model: claude-opus-4.6 | Judge: claude-opus-4.6 🔍 Full Results - additional metrics and failure investigation steps
▶ Sessions Visualisation -- interactive replay of all evaluation sessions |
|
@javiercn : Looks like the token consumption increased without much of a change in quality, based on the evals. Would you mind taking a deeper look please? |
Summary