Fix evaluation.yml run-name: quote expression so '#' isn't a YAML comment#759
Conversation
…ment The run-name added in dotnet#746 is an unquoted plain scalar containing ` #{0}`. In YAML, a space followed by '#' starts a comment, so everything from '#{0} ...' onward was stripped, leaving an unterminated ${{ }} expression. The file still parses as YAML (yaml.safe_load succeeds) but GitHub Actions rejects it ("This run likely failed because of a workflow file issue"), which broke every evaluation run on main after dotnet#746 merged. Wrapping the value in double quotes keeps the full expression intact; verified with actionlint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Note This PR is from a fork and modifies infrastructure files ( Changes to infrastructure typically need to be submitted from a branch in Please consider recreating this PR from an upstream branch. If you don't have push access to |
There was a problem hiding this comment.
Pull request overview
Fixes a GitHub Actions workflow parsing failure introduced by an unquoted run-name expression containing #, which YAML treats as a comment delimiter in plain scalars—resulting in a truncated/invalid ${{ ... }} expression and preventing the workflow from starting.
Changes:
- Quote the
run-namevalue in.github/workflows/evaluation.ymlso#remains part of the string and the expression remains intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/evaluate |
Problem
Every
evaluation.ymlrun onmainhas failed since #746 merged (13:50), with GitHub reporting "This run likely failed because of a workflow file issue" and no jobs starting. This is not caused by #754 (baseline reuse) — that feature's eval run succeeded at 13:17; the first failure is the #746 merge commit.Root cause
#746 added a
run-nameas an unquoted plain YAML scalar:In YAML, a space followed by
#begins a comment. So#{0} @ {1}', inputs.pr_number, inputs.head_sha) || '' }}is stripped as a comment, leaving an unterminated${{expression. The file still parses as valid YAML (which is whyyaml.safe_loadand a casual review pass), but the GitHub Actions workflow parser rejects the broken expression and refuses to start any run.Fix
Wrap the value in double quotes so the
#stays inside the scalar:The inner expression only uses single quotes, so double-quoting is safe.
Verification
actionlinton the fixed file: 0 errors (previously:got unexpected EOF while lexing end of string literalat line 34).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com