[dotnet-svcutil] Remove forked framework codedom and use System.CodeDom package #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem.CodeDom codegen diffs; update tests to net10.0
1. Pin System.CodeDom to 8.0.0 to avoid pulling newer (net10-rc aligned) builds that can fail at runtime on older supported runtimes. 2. Ensure the generated SvcutilBootstrapper project can always load System.CodeDom when the tool is referenced by path (global-tool/bootstrapper flow) by adding an explicit System.CodeDom.dll reference when present next to dotnet-svcutil-lib.dll, update TFMBootstrap/TFMBootstrapGlobal test baselines accordingly. 3. Remove the previously-added CodeDom output post-processing that was only needed for System.CodeDom 10.x.
1. Replace the SVCUTIL_CLOSEASYNC_WRAP comment marker with a CodeRegionDirective marker around the generated CloseAsync member. 2. Update CodeSerializer post-processing to convert the matching #region/#endregion (or VB #Region/#End Region) into #if/#endif (or #If/#End If), avoiding brace-based member-end parsing. 3. Use CodeRegionMode (netstandard2.0 compatible) for the region directive start/end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.