Fix issue 14025: [DarkMode] the item lost dot line when using the mouse to expand the dropdown panel for SelectionPanelRadioButton#14710
Open
SimonZhao888 wants to merge 2 commits into
Conversation
…se to expand the dropdown panel for SelectionPanelRadioButton
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a dark-mode rendering regression in the WinForms designer “Selection Panel” radio-button UI by ensuring the focus cue (dotted rectangle) is drawn consistently after native painting.
Changes:
- Overrides
SelectionPanelRadioButton.WndProcto interceptWM_PAINT. - Calls
base.WndProc(ref m)first to preserve native button rendering, then overlays a focus rectangle whenFocusedand focus cues are shown. - Adds basic bounds validation/inset to avoid invalid focus-rectangle drawing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14025
Root Cause
SelectionPanelRadioButton relies on native painting when used with Appearance.Button, if the focus rectangle is not drawn after native painting completes, it can be missing or inconsistent under certain themes/modes.
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Dark Mode
14025.mp4
Normal
14025-1.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow