Fix TextServicesManager scan code forwarding for TSF#11644
Open
calisto-le wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11635
Description
TextServicesManagercurrently passes0as the scan code for almost all keys when forwarding keystrokes to TSF.This change forwards
keyArgs.ScanCodeinstead, so the scan-code bits in thelParampassed toTextServicesContext.Keystrokeare populated correctly.Existing LeftShift/RightShift special handling remains unchanged.
Customer Impact
Text services, IMEs, or TIPs that rely on scan-code information will receive the correct scan code instead of just
0.Regression
No. The issue reports this as not being a regression.
Testing
Tested with a sample TextBox application using locally built WPF assemblies.
Verified that scancode matches keyArgs.ScanCode.
Risk
Low.
The change only forwards the existing scan code value.
If there is any more testing to do please let me know.
Extended Flag in lParam?
The lParam should include the extended flag for correct identifaction of all keys. Should this be added here of a seperate issue?
Microsoft Reviewers: Open in CodeFlow