Skip to content

Fix Popup/ContextMenu flicker caused by repositioning a fading out root #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h3xds1nz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Fix Popup/ContextMenu flicker caused by repositioning a fading out root #11735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...icrosoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/Primitives/Popup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,7 +1517,10 @@ private void CreateWindow(bool asyncCall)
// This ensures that a recycled HWND that is moving from one display
// to another does not undergo a WM_DPICHANGED event and thus cause a
// cascading failure.
if (PopupInitialPlacementHelper.IsPerMonitorDpiScalingActive)
// Also create a new window if the popup animation is set to Fade,
// otherwise reusing the same window will interrupt the fade-out animation,
// causing together with the call to SetWindowPos a brief flicker instead of smooth fade-in.
if (PopupInitialPlacementHelper.IsPerMonitorDpiScalingActive || PopupAnimation is PopupAnimation.Fade)
{
DestroyWindowImpl();
_positionInfo = null;
Expand Down