Skip to content

Add CodeQL comments to clarify trusted input handling in ResourcesGen… #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpaskaleva-msft wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −6
Open

Add CodeQL comments to clarify trusted input handling in ResourcesGen… #11763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4c169b
Add CodeQL comments to clarify trusted input handling in ResourcesGen…
gpaskaleva-msft Jul 8, 2026
6efdf8c
Added a missing codeql comment
gpaskaleva-msft Jul 20, 2026
42c8048
Shorten the comment for better readability
gpaskaleva-msft Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/ResourcesGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ private bool ValidResourceFiles(ITaskItem[] inputFiles)

strFileName = inputFile.ItemSpec;

if (!File.Exists(TaskHelper.CreateFullFilePath(strFileName, SourceDir)))
if (!File.Exists(TaskHelper.CreateFullFilePath(strFileName, SourceDir))) // CodeQL [SM00414] Trusted build-time input, not attacker-controlled
{
bValid = false;
Log.LogErrorWithCodeFromResources(nameof(SR.FileNotFound), strFileName);
Expand Down
10 changes: 5 additions & 5 deletions ...crosoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/UidManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private bool ManageUids()

using (Stream uidStream = new FileStream(tempFile, FileMode.Create))
{
using (Stream source = File.OpenRead(inputFile.ItemSpec))
using (Stream source = File.OpenRead(inputFile.ItemSpec)) // CodeQL [SM00414] Trusted build-time input, not attacker-controlled
{
UidWriter writer = new UidWriter(collector, source, uidStream);
writer.UpdateUidWrite();
Expand Down Expand Up @@ -297,7 +297,7 @@ private bool ManageUids()

using (Stream uidStream = new FileStream(tempFile, FileMode.Create))
{
using (Stream source = File.OpenRead(inputFile.ItemSpec))
using (Stream source = File.OpenRead(inputFile.ItemSpec)) // CodeQL [SM00414] Trusted build-time input, not attacker-controlled
{
UidWriter writer = new UidWriter(collector, source, uidStream);
writer.RemoveUidWrite();
Expand Down Expand Up @@ -371,9 +371,9 @@ private void RenameFile(string src, string dest)

private void RemoveFile(string fileName)
{
if (File.Exists(fileName))
if (File.Exists(fileName)) // CodeQL [SM00414] Trusted build-time path, not attacker-controlled
{
File.Delete(fileName);
File.Delete(fileName); // CodeQL [SM00414] Trusted build-time path, not attacker-controlled
}
}

Expand Down Expand Up @@ -476,7 +476,7 @@ private UidCollector ParseFile(string fileName)
{
UidCollector collector = new UidCollector(fileName );

using (Stream xamlStream = File.OpenRead(fileName))
using (Stream xamlStream = File.OpenRead(fileName)) // CodeQL [SM00414] Trusted build-time input, not attacker-controlled
{
XmlNamespaceManager nsmgr = new XmlNamespaceManager(new NameTable());
XmlParserContext context = new XmlParserContext(
Expand Down