Add WASM app verbosity compatibility switch#1584
Open
vitek-karas wants to merge 1 commit intodotnet:mainfrom
Open
Add WASM app verbosity compatibility switch#1584vitek-karas wants to merge 1 commit intodotnet:mainfrom
vitek-karas wants to merge 1 commit intodotnet:mainfrom
Conversation
Add --no-app-verbosity to 'wasm test-browser' so callers can keep xharness logging verbosity without forwarding '-verbosity <level>' into the app arguments. This restores a backward-compatible option for the .NET 8.0 runtime tests we investigated, where the forwarded verbosity arguments break older WASM browser tests that validate their command-line args strictly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
A faster way to validate and fix this in dotnet/runtime would be to add a case like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --no-app-verbosity to 'wasm test-browser' so callers can keep xharness logging verbosity without forwarding '-verbosity ' into the app arguments.
This restores a backward-compatible option for the .NET 8.0 runtime tests, where the forwarded verbosity arguments break older WASM browser tests that validate their command-line args strictly.
This is to unblock dotnet/runtime#126322 - which brings latest xharness to the 8.0 servicing branch.
My thinking was that it's simpler to add a backward compat switch to xharness than to backport relatively large test change in the WASM space.