Merged
Conversation
errors.As(err, &target) → errors.AsType[*T](err) (Go 1.26):
internal/sync/worker.go rateLimited() helper
internal/peeringdb/stream_test *json.SyntaxError assertion
cmd/peeringdb-plus/server_test *net.OpError probe
internal/middleware/maxbody_test *http.MaxBytesError guard
if x == "" { x = default } → cmp.Or(x, default) (Go 1.22 catch-up):
internal/web/handler.go viewMode default
internal/httperr/problem.go problem title default (StatusText)
internal/web/termrender/whois.go three descr fallback blocks
internal/sync/worker.go StartScheduler mode default
go fix reports zero actionable diffs outside generated code
(ent/rest/* has omitempty→omitzero alternative fixes deferred as
behavior changes, correctly ignored).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code Metrics Report
Code coverage of files in pull request scope (88.4%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors.As(err, &target)→errors.AsType[*T](err)(Go 1.26) in 4 call sites: sync/worker.go rateLimited(), peeringdb/stream_test.go, peeringdb-plus/server_test.go, middleware/maxbody_test.goif x == "" { x = default }→cmp.Or(x, default)(Go 1.22 catch-up) in 6 call sites across web/handler.go, httperr/problem.go, web/termrender/whois.go (×3), sync/worker.go StartSchedulergo fixreports zero actionable diffs outside generated code —ent/rest/*hasomitempty→omitzerosuggestions that go fix correctly defers as "alternative fix (behavior change)". Those are skipped becauseent/rest/is regenerated on everygo generateanyway.Intentionally skipped:
pdbcompat-check/main.gogoldenDirfallback — the default callsfindGoldenDir()which walks the filesystem, so eager evaluation viacmp.Orwould regress.proto.Int64()in test files — changing tonew(int64(N))is noise without benefit.Test plan
go build ./...go vet ./...golangci-lint run ./...(0 issues)go test -race ./...(all green)🤖 Generated with Claude Code