PTBAS-737: using consistent english language now

[MomdAli]

Locale management and formatting improvements:

• Added setSystemLocale, getSystemLocale, and applySystemLocaleOnDate methods to the DateFormatter utility class, allowing centralized management of the application's locale and consistent formatting of dates in DatePicker components. (DateFormatter.java) [1] [2]
• On application startup, the system locale is now set in DateFormatter, and the default locale is explicitly set to English to ensure predictable behavior. (App.java) [1] [2]

[MomdAli]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Reviewer Guide 🔍

(Review updated until commit c9cc12b)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Locale Initialization Order The app sets DateFormatter's system locale to the current default, then immediately overrides the JVM default to English. Verify that components created before/after this sequence use the intended locale and that English default does not unintentionally override user expectations elsewhere. DateFormatter.setSystemLocale(Locale.getDefault()); Locale.setDefault(Locale.ENGLISH); final DefaultExceptionHandler defaultExceptionHandler = new DefaultExceptionHandler(); Thread Safety The static mutable field systemLocale is updated via setSystemLocale without synchronization. If accessed or changed from multiple threads (UI vs. background), consider making it volatile or using synchronized access to avoid race conditions. public static void setSystemLocale(Locale locale) { systemLocale = locale; } public static Locale getSystemLocale() { return systemLocale; } Fragile UI Locale Assertions The test checks for localized strings like "Montag" and "06.2024". This may be brittle across JDK vendors or OS settings. Consider asserting via formatter pattern or parsing round-trip rather than string contains. @Test void applySystemLocaleShouldSetDatePickerLocale() { // GIVEN Locale defaultLocale = Locale.getDefault(); Locale.setDefault(Locale.ENGLISH); DateFormatter.setSystemLocale(Locale.GERMAN); DatePicker datePicker = new DatePicker(); LocalDate date = LocalDate.of(2024, 6, 3); // WHEN DateFormatter.applySystemLocaleOnDate(datePicker); datePicker.setValue(date); // THEN String shown = datePicker.getEditor().getText(); assertTrue(shown.contains("Montag")); assertTrue(shown.contains("06.2024")); Locale.setDefault(defaultLocale); }

[Death111]

@MomdAli I was using it the last weeks and I did not notice issues - only annoying thing is the calendar view that sunday is the first day of the week. can this be changed / also localized somehow?

[QodoAI-Agent]

Persistent review updated to latest commit c9cc12b

[Death111]

these resets did not make sense for me, as you reset it to the "wrong" locale. But it showed me this way to only set the locale for FORMAT. I created #191 to most likely replace this PR - lets review it.

[Death111]

Implemented via #191