Add organization role descriptions and tooltips to member management - #1193
Draft
aschkandw wants to merge 1 commit into
Draft
Add organization role descriptions and tooltips to member management#1193aschkandw wants to merge 1 commit into
aschkandw wants to merge 1 commit into
Conversation
Co-authored-by: aschkandw <aschkandw@users.noreply.github.com>
Deploying control-layer with
|
| Latest commit: |
ddf93b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c6628b8.control-layer.pages.dev |
| Branch Preview URL: | https://cursor-add-org-role-tooltips.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
There were two separate role systems in the product, and the organization membership roles (
owner,admin,member) had no in-UI explanation. The role<select>in member management just listed the three role names with no descriptions or tooltips, unlike the platform/system roles which already have hover-card descriptions in the user create/edit modals. This left users guessing what each org role can actually do.What changed
dashboard/src/utils/roles.ts:ORG_MEMBER_ROLES(ordered least→most privileged)formatOrgRoleForDisplaygetOrgRoleDescription— plain-language summary of each role's capabilitiesMemberManagement.tsx:<select>items (in both the invite form and the per-member role editor) with items that show a short description under each role name. A custom Radix item is used so the description appears in the dropdown but the trigger still shows only the role name.Role behavior reflected in the descriptions (sourced from backend authorization logic)
These are organization-scoped roles and are independent of platform/system roles (
StandardUser,PlatformManager, etc.).Tests
dashboard/src/utils/roles.test.tscovering the org-role helpers.MemberManagementtests asserting the info control is present (including in read-only mode) and surfaces the descriptions.pnpm run lint,tsc --noEmit, and the affected vitest suites all pass.