Thread --timeout through microblog deploy poll loop - #30
Open
superterran wants to merge 1 commit into
Open
Conversation
The deploy workflow calls `microblog_deploy.py --all --timeout 120`, but `--all` routed through `deploy()`, which never accepted a timeout parameter and always called `poll_check_endpoint()` with its default 60s. The CLI flag was silently ignored, so every recent scheduled and push deploy has hit the 60s poll cap and finished as a failure even when the Hugo build eventually completed on Micro.blog's side. Plumb `monitor_timeout` from `main()` -> `deploy()` -> `poll_check_endpoint()` so `--timeout 120` (or any override) actually reaches the poll loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main) has ended in failure with the same tail:Timeout reached (60s) after 12 pollsinpoll_check_endpoint, then exit 1.deploy.ymlcalls the script with--all --timeout 120, butdeploy()(line 261) never accepted atimeoutkwarg, so the--allcode path calledpoll_check_endpoint()with its default 60s regardless. The CLI flag was silently ignored.monitor_timeoutkwarg todeploy(), passargs.timeoutin frommain(), and hand it topoll_check_endpoint(timeout=...). No workflow changes needed — the workflow already passes--timeout 120.Test plan
Deploy to Micro.blogrun.(Timeout: 120s, interval: 5s)instead of60s.