Draft
Conversation
Contributor
Author
Max failures example
|
Contributor
Author
Biggy runner has 4CPUs |
klaukl
commented
Apr 17, 2026
| TESTID: ${{ inputs.test_id }} | ||
| NIGHTWATCH_HEADLESS: true | ||
| NIGHTWATCH_OUTPUT: true | ||
| # PW Settings |
Contributor
Author
There was a problem hiding this comment.
@tim-yao Do we want to make parallel / retry take env vars in case want to change in CI or just leave it hardcoded.
I.e. env:
TEST_WORKERS: 5
TEST_MAX_FAILURES: 5
Otherwise leave it as input but I think we said no need
I will be removing hardcode
--workers=6 \
--max-failures=10
klaukl
commented
Apr 22, 2026
| name: Run Backend tests | ||
| run: | | ||
| npm run e2e:backend -- \ | ||
| --workers=5 \ |
Contributor
Author
There was a problem hiding this comment.
Will remove this after PW max retry merge
tim-yao
reviewed
Apr 22, 2026
Comment on lines
+86
to
+87
| NIGHTWATCH_HEADLESS: true | ||
| NIGHTWATCH_OUTPUT: true |
tim-yao
reviewed
Apr 22, 2026
Comment on lines
+83
to
+84
| BROWSERSTACK_USER: ${{ secrets.TEST_BROWSERSTACK_USER }} | ||
| BROWSERSTACK_KEY: ${{ secrets.TEST_BROWSERSTACK_KEY }} |
tim-yao
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.