[SD-462] Retire dev-tools dependency#638
Conversation
vincent-gao
force-pushed
the
remove-dev-tools
branch
3 times, most recently
from
f8007a0 to
28b7e64
Compare
vincent-gao
changed the title
vincent-gao
force-pushed
the
remove-dev-tools
branch
from
28b7e64 to
bc62914
Compare
vincent-gao
force-pushed
the
remove-dev-tools
branch
4 times, most recently
from
f8fc10b to
0b8061d
Compare
vincent-gao
force-pushed
the
remove-dev-tools
branch
from
0b8061d to
fa2fbaf
Compare
|
|
||
| echo "==> Run Behat tests" | ||
| mkdir -p /tmp/artifacts/behat | ||
| ahoy cli "./vendor/bin/behat --strict --colors --tags="~@skipped" tests" |
There was a problem hiding this comment.
The order matters a lot since some modules depend on others, which also makes it hard to fully isolate the tests. So please don't change the run order. more modules will be added soon.
| - '%paths.base%/modules/tide_publication/tests/behat/features' | ||
| - '%paths.base%/modules/tide_alert/tests/behat/features' | ||
| contexts: | ||
| - Tide\Tests\Context\FeatureContext |
There was a problem hiding this comment.
FeatureContext will be shared across all modules, so it needs to be refactored into a namespaced format.
| suites: | ||
| default: | ||
| paths: | ||
| - '%paths.base%/tests/behat/features' |
There was a problem hiding this comment.
Will include more modules in future.
| And I see field "Show topic term and tags?" | ||
|
|
||
| And I should see text matching "Custom filters" | ||
| And I should not see text matching "Custom filters" |
There was a problem hiding this comment.
Based on the current logic in the code, users shouldn't see Custom filters.
| When I visit "node/add/landing_page" | ||
| And I click on the horizontal tab "Customised Header" | ||
| Then I should see an "#edit-header-style-options-fullwidtht" element | ||
| Then I should see an "#edit-header-style-options-fullwidth" element |
There was a problem hiding this comment.
seems like a typo issue.
| @@ -1,3 +1,4 @@ | |||
| @skipped | |||
There was a problem hiding this comment.
I skipped this menu test mainly because it seems to be an issue with Behat itself, or possibly an unknown issue ,where some menus created during tests aren't being cleaned up afterward, which then affects subsequent tests.
| # Blocks. | ||
| | authenticated user | admin/structure/block | 404 | | ||
| | administrator | admin/structure/block | 200 | | ||
| | site_admin | admin/structure/block | 200 | |
There was a problem hiding this comment.
This test will be handled in tide_landing_page.
vincent-gao
requested review from
anthony-malkoun,
nicksantamaria,
sharmasahil and
yeniatencio
yeniatencio
left a comment
yeniatencio
left a comment
There was a problem hiding this comment.
Thanks Vincent. LGTM
anthony-malkoun
left a comment
anthony-malkoun
left a comment
There was a problem hiding this comment.
Yep, good move Vincent. dev-tools only existed based on the assumption we were going to be building lots of separate modules but that ended up not being the case.
3 participants
Jira
https://digital-vic.atlassian.net/browse/SD-462
Changes
All tests for
tide_core,tide_api,tide_webform,tide_media,tide_event,tide_grant,tide_news,tide_landing_page, andtide_siteare now running.more details: https://github.com/dpc-sdp/tide_core/actions/runs/15023711109/job/42219070259?pr=638#step:9:29
The only thing we need to do in local development is run
ahoy build.