Phase 2 of API improvements#93

Open

moltude wants to merge 16 commits into

mainfrom

fix/api-phase-2

Commits on Apr 21, 2026

Phase 2 of API improvements

moltude
authored and
DominicBM
committed
Update src/main/scala/dpla/api/v2/search/queryBuilders/QueryBuilder.scala

authored and
DominicBM
committed
Update src/main/scala/dpla/api/v2/search/paramValidators/ParamValidator.scala

authored and
DominicBM
committed
Fix tests and misspellings

moltude
authored and
DominicBM
committed
Fix parameter validation to reject over-limit values instead of clamping (#94)

authored and
DominicBM
committed
Fix broken test

moltude
authored and
DominicBM
committed
Fix facet guard bypass via empty filter values

DominicBM
and
claude
committed
Address CodeRabbit: normalize empty facets/fields, fix error message bounds

DominicBM
and
claude
committed
Fix test failure: use exists(_.nonEmpty) for facets guard, keep filter for fields

DominicBM
and
claude
committed
fix: address CodeRabbit review — ConcurrencyLimiter, fetch limit, filter, op propagation

DominicBM
and
claude
committed
fix: restore exact hit counts and clean up query builder

DominicBM
and
claude
committed
fix: update track_total_hits test to expect true instead of 10000

DominicBM
and
claude
committed
fix: remove dead pagination depth guard; add OR operator multi_match test

DominicBM
and
claude
committed
fix: remove leftover unused pagination variables

DominicBM
and
claude
committed
test: rename outdated pagination test descriptions to reflect rejection behavior

DominicBM
and
claude
committed
fix: scope facet-only guard to ebook validator, preserving item endpoint compatibility

DominicBM
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase 2 of API improvements#93

Phase 2 of API improvements#93
moltude wants to merge 16 commits into
mainfrom
fix/api-phase-2

Commits on Apr 21, 2026

Phase 2 of API improvements

Update src/main/scala/dpla/api/v2/search/queryBuilders/QueryBuilder.scala

Update src/main/scala/dpla/api/v2/search/paramValidators/ParamValidator.scala

Fix tests and misspellings

Fix parameter validation to reject over-limit values instead of clamping (#94)

Fix broken test

Fix facet guard bypass via empty filter values

Address CodeRabbit: normalize empty facets/fields, fix error message bounds

Fix test failure: use exists(_.nonEmpty) for facets guard, keep filter for fields

fix: address CodeRabbit review — ConcurrencyLimiter, fetch limit, filter, op propagation

fix: restore exact hit counts and clean up query builder

fix: update track_total_hits test to expect true instead of 10000

fix: remove dead pagination depth guard; add OR operator multi_match test

fix: remove leftover unused pagination variables

test: rename outdated pagination test descriptions to reflect rejection behavior

fix: scope facet-only guard to ebook validator, preserving item endpoint compatibility