Fix DPLA API base_uri missing https:// scheme#311
Open
DominicBM wants to merge 1 commit into
Open
Conversation
Without the scheme HTTParty defaults to http://, causing Net::OpenTimeout when connecting to api.dp.la:80 instead of HTTPS on 443. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughConfiguration template updated to switch DPLA API endpoint from HTTP to HTTPS ( ChangesDPLA Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/settings.yml.templatehadbase_uri: api.dp.la/v2/with no URL scheme, causing HTTParty to default tohttp://and connect toapi.dp.la:80api.dp.laonly serves HTTPS; port 80 is silently dropped, resulting inNet::OpenTimeouterrorshttps://scheme; also corrected a stale "backslash" → "slash" comment in the same fileThe error surfaced in
DplaApiResponseBuilder#data_providers_for_items, which looks updataProvidernames for items shown in the hub-level website events table. The exception is caught and Sentry-reported, so users saw a degraded events table (missing contributor names) rather than a 500. Only 5 Sentry events total — this code path requires a hub-level (not contributor-scoped) events view with non-empty GA results.Note for the next deploy: since
settings.ymlis baked into the Docker image at build time (it's gitignored but not dockerignored), the localconfig/settings.ymlwill also need to be updated before the next ECR build.Test plan
config/settings.ymlto usehttps://api.dp.la/v2/before rebuilding the Docker image🤖 Generated with Claude Code
Summary by CodeRabbit