Open
Conversation
The Kpush::Kenvacc peephole pattern used n < 4 instead of n <= 4, so PUSHENVACC4 was never emitted despite existing in the runtime. Every push+envacc 4 used the generic 2-word PUSHENVACC instruction instead of the optimized 1-word PUSHENVACC4. This matches the Kenvacc case which correctly uses n <= 4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On Windows, ocamlrun outputs \r\n line endings. For argument-less
opcodes (shape = Nothing), the opcode name is the last field on the
line, so awk '{print $2}' includes the trailing \r (e.g. "ADDINT\r").
These tainted names don't match the clean entries in all.txt, causing
comm to report them as never emitted.
Opcodes with arguments are unaffected because \r attaches to the last
field (the argument), not the opcode name.
Strip \r early in the pipeline with tr -d '\r'.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.