Basic responsive layout with some styling#2
Open
daem-on wants to merge 5 commits intodrcursor:mainfrom
Open
Conversation
Owner
Author
Well, I don't think it would make sense to base off the other one, I mostly changed the same things as @kirrus, so you should see which one you prefer. The main difference is that my version uses vanilla css and no dependencies, as opposed to the merged one which uses bootstrap. I set the layout and scaling of the elements by hand, so it works a bit better than bootstrap's automatic layout. So yeah, if you prefer the bootstrap version, my changes won't be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not much, but I think it's an improvement, main things are changes to the layout, most things are sized adapting to the viewport size, also changed the font to Lato, but it can be anything else I just like this font (and it's free).
Had to merge the new changes in midway through, so some of that is a little rough, would like to work on it more though, please tell me what you think.
Also this could probably use some colors, I didn't change anything about the white-black color scheme.