fix: suggestion for handling terminated deploys

[GangGreenTemperTatum]

i noticed that locally, when aborting the agent deploy still reflects running and doesnt look to terminate according to the UI and cli:

╭─────────────┬────────────────────────────────────────────────────╮
│          id │ 00fb725c-3dd2-405a-ab44-93af79972788               │
│         key │ khaki-mustang                                      │
│        name │ -                                                  │
│    revision │ 1                                                  │
│ last status │ deploying                                          │
│     created │ Tue Dec 17 13:25:34 2024                           │
│             │                                                    │
│      latest │ ╭─────────┬──────────────────────────────────────╮ │
│             │ │      id │ 106c84c4-c5df-48c8-8f3a-15c3770af5bd │ │
│             │ │ created │ Tue Dec 17 13:25:34 2024             │ │
│             │ │   notes │ ads first iteration                  │ │
│             │ ╰─────────┴──────────────────────────────────────╯ │
╰─────────────┴────────────────────────────────────────────────────╯

suggestion fix, apologies if im missing some kind of context or anything here 🙂

[linear]

ENG-656 Bug: aborted `dn agent deploy` fails to terminate

i noticed that locally, when aborting the agent deploy still reflects running and doesnt look to terminate according to the UI and cli:

image.png

╭─────────────┬────────────────────────────────────────────────────╮
│          id │ 00fb725c-3dd2-405a-ab44-93af79972788               │
│         key │ khaki-mustang                                      │
│        name │ -                                                  │
│    revision │ 1                                                  │
│ last status │ deploying                                          │
│     created │ Tue Dec 17 13:25:34 2024                           │
│             │                                                    │
│      latest │ ╭─────────┬──────────────────────────────────────╮ │
│             │ │      id │ 106c84c4-c5df-48c8-8f3a-15c3770af5bd │ │
│             │ │ created │ Tue Dec 17 13:25:34 2024             │ │
│             │ │   notes │ ads first iteration                  │ │
│             │ ╰─────────┴──────────────────────────────────────╯ │
╰─────────────┴────────────────────────────────────────────────────╯

suggestion fix, apologies if im missing some kind of context or anything here 🙂

[evilsocket]

@GangGreenTemperTatum help me understand this PR: as far as I can tell we don't have any /api/strikes/runs/{run}/terminate route, so this can't work ... what am I missing?

[GangGreenTemperTatum]

@GangGreenTemperTatum help me understand this PR: as far as I can tell we don't have any /api/strikes/runs/{run}/terminate route, so this can't work ... what am I missing?

hey @evilsocket , my apologies i thought this was the case and totally my misinterpretation - sorry for wasting your time on this, i was lacking some context

[evilsocket]

@GangGreenTemperTatum never apologize for wanting to help! <3