Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

fix: sanitizing agent name before pushing to docker registry (ENG-672)#27

Merged
evilsocket merged 1 commit intomainfrom
simone/eng-672-cli-strikes-always-lowercase-the-agent-name
Dec 18, 2024
Merged

fix: sanitizing agent name before pushing to docker registry (ENG-672)#27
evilsocket merged 1 commit intomainfrom
simone/eng-672-cli-strikes-always-lowercase-the-agent-name

Conversation

@evilsocket
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Dec 18, 2024

ENG-672 CLI / Strikes: always lowercase the agent name

As per https://docs.google.com/document/d/17aHyIYkQvNZGKPPFUGPzu6KtrlD4WpMdu-9-vLyWqVo/edit?tab=t.0 :

  • Can you just str.lowercase() for the user? Or throw an error earlier in some sort of linting step? This was on the push.
    • `http+docker://localhost/v1.47/images/sha256:eeeb15501b1b24b0d6dd4b9f5e6c7594ee4d5d6dd165ec644f3e85beeb76e71c/tag?tag=eb76e71c&repo=registry.dreadnode.io%2Fjoe%2Fagents%2FMorpheus_Falco&force=0: Bad Request ("invalid reference format: repository name (joe/agents/Morpheus_Falco) must be lowercase")`
    • This is in the strikes beta docs: https://dreadnode.notion.site/strikes-beta-program#1571ad120376802aa7f1e9c73f7db6f7
      • But that name triggers the same problem
      • http+docker://localhost/v1.47/images/sha256:f98eee2e0fd74570d65813b5ea1a16b8d6459158809e9e12793e505499577db0/tag?tag=99577db0&repo=r
      • egistry.dreadnode.io%2Fjoe%2Fagents%2FMy_First_Falco&force=0: Bad Request ("invalid reference format: repository name
      • (joe/agents/My_First_Falco) must be lowercase")

@evilsocket evilsocket merged commit 348d0c6 into main Dec 18, 2024
1 check passed
@evilsocket evilsocket deleted the simone/eng-672-cli-strikes-always-lowercase-the-agent-name branch January 7, 2025 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant