Fix AD group import TypeError on PHP 8.1+#46
Open
nicdavidson wants to merge 1 commit into
Open
Conversation
The role_adldap_by_role_id relation value must be an array of arrays (one record per related model). The flat array caused BaseModel to iterate string values into Model::__construct(), which fatally fails under PHP 8.1+ strict typing. Regression introduced in ab15144 (2017).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role_adldap_by_role_idrelation value in an additional array soBaseModel::setAttribute()iterates an array of records instead of string valuesTypeError: Model::__construct(): Argument #1 ($attributes) must be of type array, string givenwhen runningphp artisan df:ad-group-importon PHP 8.1+Test plan
php artisan df:ad-group-import <service>against an AD server with groupsrole_adldaprelation (DN stored)