test: add smoke tests for CLI subcommands#409
Open
Shreyas-Gowda26 wants to merge 2 commits intodreamlessx:mainfrom
Open
test: add smoke tests for CLI subcommands#409Shreyas-Gowda26 wants to merge 2 commits intodreamlessx:mainfrom
Shreyas-Gowda26 wants to merge 2 commits intodreamlessx:mainfrom
Conversation
Owner
|
Welcome @Shreyas-Gowda26! Nice first contribution — clean smoke tests that cover all three CLI subcommands without needing GPU or model weights. This is exactly what #397 asked for. CI is failing on one tiny issue — missing newline at end of file: echo "" >> tests/test_cli_smoke.py
git add tests/test_cli_smoke.py
git commit -m "style: add trailing newline"
git pushOnce that's fixed, I'll merge it right away! |
Author
|
Hey @dreamlessx Fixed! Added the trailing newline. Ready for review when you get a chance! |
Owner
|
Thanks for the fix @Shreyas-Gowda26! CI needs to re-run — waiting on workflow approval for the updated commit. |
Owner
|
Trailing newline is fixed, but CI is now failing on formatting — ruff format tests/test_cli_smoke.py
git add tests/test_cli_smoke.py
git commit -m "style: format test file"
git pushOne more push and we're good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #397
Added tests/test_cli_smoke.py covering CLI subcommand smoke tests:
No GPU or model weights required — help flags only.