Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
💬 리뷰 요구사항(선택)
그런데 타입캐스팅이 무조건 필요한 구조라면, 전략패턴에서 상위 인터페이스(PickService)를 반환하는 방식의 추상화 구조가 오히려 복잡성을 증가시키는 건 아닐까 하는 생각이 들기도 합니다.
차라리 PickServiceStrategy 에 V1, V2 메서드를 분리하는 건 어떨까..싶은데 세웅님께 조언을 구합니다~!!