Skip to content

Updated PHPStan config to ignore array types for hooks '@return' params. #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexSkrypnyk merged 1 commit into from
Apr 8, 2026
Merged

Updated PHPStan config to ignore array types for hooks '@return' params. #2453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions .vortex/installer/tests/Fixtures/handler_process/_baseline/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,18 @@ parameters:
treatPhpDocTypesAsCertain: false

ignoreErrors:
-
# Since tests and data providers do not have to have parameter docblocks,
- # Hook implementations do not provide full type information for
# parameters or return values in iterable type arrays.
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
- web/sites/default/includes
reportUnmatched: false
- # Since tests and data providers do not have to have parameter docblocks,
# it is not possible to specify the type of the parameter, so we ignore
# this error.
message: '#.*no value type specified in iterable type array.#'
Expand All @@ -40,17 +50,3 @@ parameters:
- web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
# Hook implementations do not provide docblocks for parameters, so there
# is no way to provide this information.
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
- web/sites/default/includes
reportUnmatched: false
33 changes: 16 additions & 17 deletions .vortex/installer/tests/Fixtures/handler_process/hosting_acquia/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,29 @@
- tests

excludePaths:
@@ -36,8 +36,8 @@
# this error.
message: '#.*no value type specified in iterable type array.#'
paths:
- - web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
+ - docroot/modules/custom/*/tests/*
+ - docroot/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -45,12 +45,12 @@
# is no way to provide this information.
message: '#.* with no value type specified in iterable type array#'
@@ -34,12 +34,12 @@
# parameters or return values in iterable type arrays.
message: '#.*no value type specified in iterable type array#'
paths:
- - web/modules/custom/*
- - web/themes/custom/*
+ - docroot/modules/custom/*
+ - docroot/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
- - web/sites/default/includes
+ - docroot/sites/default/includes
reportUnmatched: false
- # Since tests and data providers do not have to have parameter docblocks,
# it is not possible to specify the type of the parameter, so we ignore
@@ -46,7 +46,7 @@
# this error.
message: '#.*no value type specified in iterable type array.#'
paths:
- - web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
+ - docroot/modules/custom/*/tests/*
+ - docroot/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
33 changes: 16 additions & 17 deletions .vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,29 @@
- tests

excludePaths:
@@ -36,8 +36,8 @@
# this error.
message: '#.*no value type specified in iterable type array.#'
paths:
- - web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
+ - docroot/modules/custom/*/tests/*
+ - docroot/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -45,12 +45,12 @@
# is no way to provide this information.
message: '#.* with no value type specified in iterable type array#'
@@ -34,12 +34,12 @@
# parameters or return values in iterable type arrays.
message: '#.*no value type specified in iterable type array#'
paths:
- - web/modules/custom/*
- - web/themes/custom/*
+ - docroot/modules/custom/*
+ - docroot/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
- - web/sites/default/includes
+ - docroot/sites/default/includes
reportUnmatched: false
- # Since tests and data providers do not have to have parameter docblocks,
# it is not possible to specify the type of the parameter, so we ignore
@@ -46,7 +46,7 @@
# this error.
message: '#.*no value type specified in iterable type array.#'
paths:
- - web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
+ - docroot/modules/custom/*/tests/*
+ - docroot/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
19 changes: 9 additions & 10 deletions .vortex/installer/tests/Fixtures/handler_process/theme_claro/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
19 changes: 9 additions & 10 deletions .vortex/installer/tests/Fixtures/handler_process/theme_olivero/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
19 changes: 9 additions & 10 deletions .vortex/installer/tests/Fixtures/handler_process/theme_stark/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
4 changes: 1 addition & 3 deletions .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@@ -38,7 +38,6 @@
@@ -48,5 +48,4 @@
paths:
- web/modules/custom/*/tests/*
- web/themes/custom/*/tests/*
- - tests/phpunit/*
reportUnmatched: false
-
# Hook implementations do not provide docblocks for parameters, so there
4 changes: 1 addition & 3 deletions ...x/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@@ -38,7 +38,6 @@
@@ -48,5 +48,4 @@
paths:
- web/modules/custom/*/tests/*
- web/themes/custom/*/tests/*
- - tests/phpunit/*
reportUnmatched: false
-
# Hook implementations do not provide docblocks for parameters, so there
19 changes: 9 additions & 10 deletions ...ex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
Empty file removed ...r_process/tools_groups_no_fe_lint_no_theme/web/modules/custom/sw_demo/js/-sw_demo.test.js
View file
Open in desktop
Empty file.
19 changes: 9 additions & 10 deletions ...ler/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
19 changes: 9 additions & 10 deletions .vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_no_theme/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
4 changes: 1 addition & 3 deletions .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@@ -38,7 +38,6 @@
@@ -48,5 +48,4 @@
paths:
- web/modules/custom/*/tests/*
- web/themes/custom/*/tests/*
- - tests/phpunit/*
reportUnmatched: false
-
# Hook implementations do not provide docblocks for parameters, so there
4 changes: 1 addition & 3 deletions .vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@@ -38,7 +38,6 @@
@@ -48,5 +48,4 @@
paths:
- web/modules/custom/*/tests/*
- web/themes/custom/*/tests/*
- - tests/phpunit/*
reportUnmatched: false
-
# Hook implementations do not provide docblocks for parameters, so there
19 changes: 9 additions & 10 deletions .vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_no_theme/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@
- web/sites/default/settings.php
- web/sites/default/includes
- tests
@@ -37,7 +36,6 @@
@@ -35,7 +34,6 @@
message: '#.*no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
- # Included settings files are not aware about global variables.
message: '#Variable .* might not be defined.#'
paths:
@@ -47,6 +45,5 @@
message: '#.*no value type specified in iterable type array.#'
paths:
- web/modules/custom/*/tests/*
- - web/themes/custom/*/tests/*
- tests/phpunit/*
reportUnmatched: false
-
@@ -46,7 +44,6 @@
message: '#.* with no value type specified in iterable type array#'
paths:
- web/modules/custom/*
- - web/themes/custom/*
reportUnmatched: false
-
# Included settings files are not aware about global variables.
Loading
Loading