Removed 'fullscreen_algorithm' option from Behat Screenshots settings.#2454
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
==========================================
- Coverage 79.88% 79.42% -0.47%
==========================================
Files 128 121 -7
Lines 6861 6702 -159
Branches 47 3 -44
==========================================
- Hits 5481 5323 -158
+ Misses 1380 1379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Removed the
fullscreen_algorithmoption from Behat Screenshots configuration. This setting (stitchorresize) is no longer supported by the Behat Screenshots extension, so keeping it in the configuration is unnecessary and could cause confusion.Changes
fullscreen_algorithm: resizeline from the Behat Screenshots extension settings..vortex/installer/tests/Fixtures/handler_process/_baseline/behat.yml): Matching removal to keep the baseline fixture in sync with the template.Summary by CodeRabbit