Skip to content

Removed 'fullscreen_algorithm' option from Behat Screenshots settings.#2454

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/update-behat-screenshot-settings
Apr 8, 2026
Merged

Removed 'fullscreen_algorithm' option from Behat Screenshots settings.#2454
AlexSkrypnyk merged 1 commit intomainfrom
feature/update-behat-screenshot-settings

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Member

@AlexSkrypnyk AlexSkrypnyk commented Apr 8, 2026

Summary

Removed the fullscreen_algorithm option from Behat Screenshots configuration. This setting (stitch or resize) is no longer supported by the Behat Screenshots extension, so keeping it in the configuration is unnecessary and could cause confusion.

Changes

  • behat.yml: Removed fullscreen_algorithm: resize line from the Behat Screenshots extension settings.
  • Installer fixture (.vortex/installer/tests/Fixtures/handler_process/_baseline/behat.yml): Matching removal to keep the baseline fixture in sync with the template.

Summary by CodeRabbit

  • Chores
    • Updated screenshot extension configuration to use default fullscreen algorithm instead of a fixed resize setting during testing.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf7b3b79-3499-4e18-8db7-4526e99ffa52

📥 Commits

Reviewing files that changed from the base of the PR and between d0d7659 and 4c91cdf.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/behat.yml is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
  • behat.yml

Walkthrough

The behat.yml configuration file is modified to remove the fullscreen_algorithm: resize setting from the BehatScreenshotExtension configuration, allowing the extension to use its default fullscreen algorithm.

Changes

Cohort / File(s) Summary
Configuration Update
behat.yml
Removed fullscreen_algorithm: resize from BehatScreenshotExtension settings, reverting to default behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line removed, so clean and bright,
Default algorithms now shine with light,
No resize constraints to hold us down,
The fullscreen screenshots wear nature's crown! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-behat-screenshot-settings

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (rebase) April 8, 2026 00:38
@AlexSkrypnyk AlexSkrypnyk disabled auto-merge April 8, 2026 00:38
@AlexSkrypnyk AlexSkrypnyk merged commit 794d348 into main Apr 8, 2026
17 of 22 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/update-behat-screenshot-settings branch April 8, 2026 00:39
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex Apr 8, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.38.0 milestone Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk
Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (d0d7659) to head (4c91cdf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   79.88%   79.42%   -0.47%     
==========================================
  Files         128      121       -7     
  Lines        6861     6702     -159     
  Branches       47        3      -44     
==========================================
- Hits         5481     5323     -158     
+ Misses       1380     1379       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant