Skip to content

Added 'drush' directory to '.gitignore.artifact' and sorted entries.#2459

Merged
AlexSkrypnyk merged 2 commits intomainfrom
feature/artifact-drush-dir
Apr 13, 2026
Merged

Added 'drush' directory to '.gitignore.artifact' and sorted entries.#2459
AlexSkrypnyk merged 2 commits intomainfrom
feature/artifact-drush-dir

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Member

@AlexSkrypnyk AlexSkrypnyk commented Apr 13, 2026

Summary

Added !/drush/ to .gitignore.artifact so that the drush/ directory is included in the git artifact deployment. Without this entry, drush site aliases and other drush configuration files were excluded from the artifact, causing drush commands to fail in production environments. The entries in the "Do not ignore required files" block were also sorted alphabetically for consistency. All installer fixture/snapshot files were updated to match.

Changes

  • .gitignore.artifact — Added !/drush/ entry and sorted all entries in the "Do not ignore required files" block alphabetically (!.env, !/config/, !/drush/, !/scripts/, !/vendor/, !composer.json)
  • Installer fixtures — Updated five fixture snapshots under .vortex/installer/tests/Fixtures/ to reflect the same changes, keeping tests in sync with the source file
  • Deployment test — Added assertion in SubtestDeploymentTrait::assertDeploymentFilesPresent() to verify the drush directory exists in the built artifact

Summary by CodeRabbit

  • Chores
    • Updated version control ignore rules to explicitly un-ignore certain required files (including .env) and add an exception for the drush directory.
  • Tests
    • Added a deployment validation to automated tests to ensure the drush directory is present in build artifacts.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 77de5bd5-a6d9-4abc-94e2-102dd663a30d

📥 Commits

Reviewing files that changed from the base of the PR and between a1739c1 and c881e82.

📒 Files selected for processing (1)
  • .vortex/tests/phpunit/Traits/Subtests/SubtestDeploymentTrait.php

Walkthrough

Reordered .env in .gitignore.artifact allowlist and added an explicit un-ignore rule for drush/. Also added a deployment assertion to verify the drush directory exists in artifact deployment tests.

Changes

Cohort / File(s) Summary
Gitignore rules
​.gitignore.artifact
Moved .env earlier within the "Do not ignore required files" section and added an explicit exception !/drush/ to un-ignore the drush directory.
Deployment tests
vortex/tests/phpunit/Traits/Subtests/SubtestDeploymentTrait.php
Added an assertion in assertDeploymentFilesPresent(...) to check that the ${dir}/drush directory exists in the deployment artifact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

AUTOMERGE

Poem

I’m a rabbit in the repo, light on my paw,
I nudged .env higher, found a new law,
drush/ now waved from the un-ignore shore,
Tests peek inside — the folder’s there, hoorah! 🐇✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding a drush directory exception to .gitignore.artifact and sorting entries, which aligns with the actual modifications to both the configuration file and test assertions.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/artifact-drush-dir

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (d004d99) to head (c881e82).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   79.88%   79.42%   -0.47%     
==========================================
  Files         128      121       -7     
  Lines        6861     6702     -159     
  Branches       47        3      -44     
==========================================
- Hits         5481     5323     -158     
+ Misses       1380     1379       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk
Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.53% (201/204)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk AlexSkrypnyk merged commit e4c15ff into main Apr 13, 2026
30 checks passed
@AlexSkrypnyk AlexSkrypnyk added this to the 1.38.0 milestone Apr 13, 2026
@AlexSkrypnyk AlexSkrypnyk deleted the feature/artifact-drush-dir branch April 13, 2026 06:41
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant