Added 'drush' directory to '.gitignore.artifact' and sorted entries.#2459
Added 'drush' directory to '.gitignore.artifact' and sorted entries.#2459AlexSkrypnyk merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughReordered Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 79.88% 79.42% -0.47%
==========================================
Files 128 121 -7
Lines 6861 6702 -159
Branches 47 3 -44
==========================================
- Hits 5481 5323 -158
+ Misses 1380 1379 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Summary
Added
!/drush/to.gitignore.artifactso that thedrush/directory is included in the git artifact deployment. Without this entry, drush site aliases and other drush configuration files were excluded from the artifact, causing drush commands to fail in production environments. The entries in the "Do not ignore required files" block were also sorted alphabetically for consistency. All installer fixture/snapshot files were updated to match.Changes
.gitignore.artifact— Added!/drush/entry and sorted all entries in the "Do not ignore required files" block alphabetically (!.env,!/config/,!/drush/,!/scripts/,!/vendor/,!composer.json).vortex/installer/tests/Fixtures/to reflect the same changes, keeping tests in sync with the source fileSubtestDeploymentTrait::assertDeploymentFilesPresent()to verify thedrushdirectory exists in the built artifactSummary by CodeRabbit