[#2355] Hardened Renovate config with PR limits, GHA auto-merge and dashboard labels.#2467
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR updates Renovate configuration and documentation: it enables automerge for the GitHub Actions update group (CI must pass and repo must allow auto-merge), replaces a deprecated preset with dependency dashboard labels, and adds global PR throughput and presentation settings ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerLet us write the prompt for your AI agent so you can ship faster (with fewer bugs). View plan for ticket: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.vortex/docs/content/tools/renovate.mdx:
- Around line 52-53: The doc incorrectly states that commitBodyTable affects the
PR body; update the description of commitBodyTable to say it inserts a
version-comparison table into the commit message body (not the PR body). Locate
the mention of commitBodyTable in the text (the line showing "**PR body table:**
`commitBodyTable: true`") and rephrase it to something like "Commit message body
table: `commitBodyTable: true` - include a version-comparison table in the
commit message body." Ensure the term `commitBodyTable` remains highlighted so
readers can find the config name easily.
- Around line 28-31: Update the paragraph that currently says auto-merge happens
"after CI passes" and only mentions enabling "Allow auto-merge" (the sentence
referencing the "GitHub Actions" group and the phrase "Allow auto-merge") to
also require branch protection: instruct readers to enable "Require status
checks to pass before merging" in branch protection and select at least one
required status check so CI must pass before auto-merge; rephrase the line to
clearly state both prerequisites (Allow auto-merge enabled and branch protection
requiring status checks).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: aa6a1568-71da-439f-b468-ad75ee664098
⛔ Files ignored due to path filters (3)
.vortex/installer/tests/Fixtures/handler_process/_baseline/renovate.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/renovate.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_gha/renovate.jsonis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (2)
.vortex/docs/content/tools/renovate.mdxrenovate.json
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
===========================================
- Coverage 79.93% 69.42% -10.52%
===========================================
Files 129 43 -86
Lines 6883 2590 -4293
Branches 47 3 -44
===========================================
- Hits 5502 1798 -3704
+ Misses 1381 792 -589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Code coverage (threshold: 90%) Per-class coverage |
Closes #2355
Summary
Hardens the Renovate configuration based on a targeted gap analysis against the
Akollade renovate-config. The
changes add explicit PR throughput controls, improve PR body presentation, label
the dependency dashboard issue, and enable auto-merge for the GitHub Actions
group. Items that were out of scope or explicitly declined by the maintainer are
noted below; vulnerability-alerts configuration was split to #2466 to keep this
PR focused.
Changes
Renovate configuration (
renovate.json)$schemapointing to the official Renovate JSON schema for IDEautocomplete and validation.
dependencyDashboardLabels: ["Dependencies"]so the Renovatedependency dashboard issue carries the
Dependencieslabel.prConcurrentLimit: 10- caps open Renovate PRs across all groups to10 at any time.
prHourlyLimit: 0- removes the hourly cap; per-group schedulesprovide the throttling instead.
commitBodyTable: true- multi-package group PRs include aversion-comparison table in the PR body.
automerge: trueto the "GitHub Actions - All - Major, minor andpatch" package rule - GHA update PRs are auto-merged after CI passes.
ignorePresets: [":prHourlyLimit2"]- now redundant becauseprHourlyLimit: 0is set explicitly.Documentation (
.vortex/docs/content/tools/renovate.mdx)group PRs are auto-merged after CI passes and that "Allow auto-merge" must
be enabled in repository settings (Settings > General > Pull Requests).
prConcurrentLimit,prHourlyLimit,commitBodyTable, anddependencyDashboardLabels.Installer fixtures
Mechanical regeneration of
.vortex/installer/tests/Fixtures/handler_process/snapshots (
_baseline,timezone_circleci,timezone_gha) viaahoy update-snapshotsto pick up the rootrenovate.jsonchanges.Related work
vulnerabilityAlertsconfiguration (split off from this issue).Items explicitly out of scope
The following items from the gap analysis were reviewed and declined or deferred
by the maintainer:
require-devsplitplatformAutomerge: trueSummary by CodeRabbit
New Features
Changes