Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"drupal/gin": "^4.0.6",
"drupal/gin_toolbar": "^2",
"drupal/google_tag": "^2.0.9",
"drupal/highlight_js": "^1.2",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"drupal/lagoon_logs": "^3.0.1",
"drupal/metatag": "^2.2",
"drupal/pathauto": "^1.14",
Expand Down
74 changes: 63 additions & 11 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions config/default/core.extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ module:
gin_toolbar: 0
google_tag: 0
help: 0
highlight_js: 0
history: 0
image: 0
image_captcha: 0
Expand Down
3 changes: 3 additions & 0 deletions config/default/editor.editor.civictheme_rich_text.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ dependencies:
- filter.format.civictheme_rich_text
module:
- ckeditor5
- highlight_js
_core:
default_config_hash: SztHd9Hrw3-1EuKex-O6V-Kc5EpxLGsSam2HEDXSgDM
format: civictheme_rich_text
Expand Down Expand Up @@ -40,6 +41,8 @@ settings:
- subscript
- '|'
- sourceEditing
- '|'
- highlightJs
plugins:
ckeditor5_alignment:
enabled_alignments:
Expand Down
9 changes: 8 additions & 1 deletion config/default/filter.format.civictheme_rich_text.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ dependencies:
- core.entity_view_mode.media.embedded
module:
- editor
- highlight_js
- linkit
- media
_core:
Expand Down Expand Up @@ -44,9 +45,15 @@ filters:
status: true
weight: -50
settings:
allowed_html: '<br> <p class="ct-text-large ct-text-small text-align-left text-align-center text-align-right"> <h2 id class> <h3 id class="text-align-left text-align-center text-align-right"> <h4 id class="text-align-left text-align-center text-align-right"> <h5 id class="text-align-left text-align-center text-align-right"> <h6 id class="text-align-left text-align-center text-align-right"> <a class="ct-button ct-theme-light ct-theme-dark ct-button--primary ct-button--regular ct-button--secondary ct-button--large" hreflang target title href data-entity-type data-entity-uuid data-entity-substitution> <table class="ct-theme-light ct-theme-dark ct-table ct-table--striped"> <cite> <dl> <dt> <dd> <img src alt data-entity-type data-entity-uuid> <drupal-entity alt title data-entity-type data-entity-uuid data-entity-embed-display data-entity-embed-display-settings data-align data-caption data-embed-button> <span class="ct-visually-hidden"> <svg role viewBox aria-hidden width height class="ct-icon"> <path d> <blockquote cite> <drupal-media title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <u> <code class="language-*"> <pre class="text-align-left text-align-center text-align-right"> <s> <sub> <sup> <ul type> <ol type start> <li> <tr> <td rowspan colspan> <th rowspan colspan> <thead> <tbody> <tfoot> <caption>'
allowed_html: '<br> <p class="ct-text-large ct-text-small text-align-left text-align-center text-align-right"> <h2 id class> <h3 id class="text-align-left text-align-center text-align-right"> <h4 id class="text-align-left text-align-center text-align-right"> <h5 id class="text-align-left text-align-center text-align-right"> <h6 id class="text-align-left text-align-center text-align-right"> <a class="ct-button ct-theme-light ct-theme-dark ct-button--primary ct-button--regular ct-button--secondary ct-button--large" hreflang target title href data-entity-type data-entity-uuid data-entity-substitution> <table class="ct-theme-light ct-theme-dark ct-table ct-table--striped"> <cite> <dl> <dt> <dd> <img src alt data-entity-type data-entity-uuid> <drupal-entity alt title data-entity-type data-entity-uuid data-entity-embed-display data-entity-embed-display-settings data-align data-caption data-embed-button> <span class="ct-visually-hidden"> <svg role viewBox aria-hidden width height class="ct-icon"> <path d> <blockquote cite> <drupal-media title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <u> <code class="language-*"> <pre class="text-align-left text-align-center text-align-right"> <s> <sub> <sup> <ul type> <ol type start> <li> <tr> <td rowspan colspan> <th rowspan colspan> <thead> <tbody> <tfoot> <caption> <highlight-js data-plugin-config data-plugin-id>'
filter_html_help: true
filter_html_nofollow: false
highlight_js:
id: highlight_js
provider: highlight_js
status: true
weight: -40
settings: { }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix YAML empty-brace formatting (YAMLlint error)

settings: { } uses spaces inside the empty mapping braces, matching the same YAMLlint violation as in highlight_js.settings.yml.

🛠️ Proposed fix
-    settings: {  }
+    settings: {}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
settings: { }
settings: {}
🧰 Tools
🪛 YAMLlint (1.38.0)

[error] 56-56: too many spaces inside empty braces

(braces)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@config/default/filter.format.civictheme_rich_text.yml` at line 56, Replace
the malformed empty-mapping syntax in filter.format.civictheme_rich_text.yml:
change the line "settings: {  }" to use a compact empty mapping "settings: {}"
(no spaces inside braces) so it matches YAMLlint rules and the style used in
highlight_js.settings.yml.

filter_html_escape:
id: filter_html_escape
provider: filter
Expand Down
12 changes: 12 additions & 0 deletions config/default/highlight_js.settings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
copy_enable: true
copy_bg_transparent: false
copy_bg_color: '#4243b1'
copy_txt_color: '#ffffff'
copy_btn_text: ''
copy_success_text: ''
success_txt_color: '#ffffff'
role_copy_access: { }
languages: { }
Comment on lines +8 to +9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix YAML empty-brace formatting (YAMLlint error)

Both role_copy_access and languages use { } (spaces inside braces), which fails YAMLlint. Use {} to represent empty mappings.

🛠️ Proposed fix
-role_copy_access: {  }
-languages: {  }
+role_copy_access: {}
+languages: {}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
role_copy_access: { }
languages: { }
role_copy_access: {}
languages: {}
🧰 Tools
🪛 YAMLlint (1.38.0)

[error] 8-8: too many spaces inside empty braces

(braces)


[error] 9-9: too many spaces inside empty braces

(braces)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@config/default/highlight_js.settings.yml` around lines 8 - 9, Replace the
invalid empty-brace formatting for the YAML keys role_copy_access and languages
by changing their values from "{  }" to "{}" so they are valid empty mappings
for YAMLlint; update both occurrences (role_copy_access: {  } ->
role_copy_access: {} and languages: {  } -> languages: {}) and ensure no
trailing spaces remain inside the braces.

theme: github
success_bg_transparent: false
success_bg_color: '#4243b1'
Loading