Allow integrator to define source/interface IP + json header update#326
Open
RickKukiela wants to merge 2 commits intodrewm:masterfrom
Open
Allow integrator to define source/interface IP + json header update#326RickKukiela wants to merge 2 commits intodrewm:masterfrom
RickKukiela wants to merge 2 commits intodrewm:masterfrom
Conversation
…defaults to null for backward compatibility) which allows an integrator to set an override interface IP address to in the CURL requests. Strict typing was left out to keep code style similar. When used in the curl connection method, the `CURLOPT_INTERFACE` is only implemented when a non-empty string value is present in the $source_ip class property.
…est to the standard `application/json` value. While this is not currently causing an issue, MailChimp's API is plain REST with JSON and not JSON:API. All examples in their documentation use `application/json`. This is just future proofing given their use of Akami WAF Gateways where this has the potential to cause issues in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new constructor parameter
$source_ipwhich when set results in CURLOPT_INTERFACE being set to the provided value, forcing curl to use the provided IP address for outbound connections.I also noticed that Accept and Content-Type headers used a JSON:API specific
application/vnd.api+jsonwhich conflicts with the API documentation and has future potential to cause issues connecting through MC's Akami WAF gateway system. This is a separate commit within the PR.