Skip to content

Dev fix #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZR233 merged 2 commits into from
Jan 29, 2026
Merged

Dev fix #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d1f37
fix: 更新所有 Cargo.toml 文件中的仓库地址
ZR233 Jan 29, 2026
9070d5f
fix: 更新 release.yml 工作流以使用最新的 checkout 和 Rust 工具链配置
ZR233 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,21 @@ jobs:
if: ${{ github.repository_owner == 'drivercraft' && (github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success') }}
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- &checkout
name: Checkout repository
uses: actions/checkout@v6
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkout action is updated to v6 in the new job steps, but the existing 'build-binaries' job still uses v4 (line 70). For consistency, all checkout actions in the workflow should use the same version. Consider updating line 70 to also use v6, or verify that v6 is the intended version for this workflow.

Suggested change
uses: actions/checkout@v6
uses: actions/checkout@v4

Copilot uses AI. Check for mistakes.
with:
fetch-depth: 0
persist-credentials: false
- &install-rust
name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable

- &setup-libudenv:
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor name has a syntax error. It should be 'setup-libudev' (without the colon), not 'setup-libudenv:'. YAML anchor definitions should not end with a colon. This will cause the workflow to fail.

Copilot uses AI. Check for mistakes.
uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: libudev-dev
version: 1.0

- name: Release with release-plz
uses: release-plz/action@v0.5
Expand All @@ -26,6 +39,27 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
# Create a PR with the new versions and changelog, preparing the next release.
release-plz-pr:
name: Release-plz PR
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
concurrency:
group: release-plz-${{ github.ref }}
cancel-in-progress: false
steps:
- *checkout
- *install-rust
- *setup-libudenv
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor name has a typo: 'setup-libudenv' should be 'setup-libudev' (missing 'd' in 'udev'). This should match the corrected anchor definition on line 29.

Copilot uses AI. Check for mistakes.
Comment on lines +53 to +55
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions YAML anchors can only be referenced within the same job. The anchors defined in the 'release-plz' job (lines 19, 25, 29) cannot be referenced in a different job ('release-plz-pr'). Each job needs to define its own steps explicitly or redefine the anchors.

Suggested change
- *checkout
- *install-rust
- *setup-libudenv
- name: Checkout repository
uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
- uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: libudev-dev
version: 1.0

Copilot uses AI. Check for mistakes.
- name: Run release-plz
uses: release-plz/action@v0.5
with:
command: release-pr
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

build-binaries:
needs: release-plz
Expand Down
4 changes: 1 addition & 3 deletions fitimage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@ version = "0.1.1"
edition = "2021"
authors = ["周睿 <zrufo747@outlook.com>"]
description = "A Rust library for creating U-Boot compatible FIT images"
documentation = "https://docs.rs/fitimage"
license = "MIT OR Apache-2.0"
readme = "README.md"
categories = ["embedded", "development-tools", "os"]
keywords = ["u-boot", "boot", "fit-image", "embedded"]
repository = "https://github.com/ZR233/ostool"
repository = "https://github.com/drivercraft/ostool"

[dependencies]
# 核心依赖
Expand Down
4 changes: 1 addition & 3 deletions jkconfig/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
authors = ["周睿 <zrufo747@outlook.com>"]
categories = ["command-line-interface", "config"]
description = "A Cursive-based TUI component library for JSON Schema configuration"
documentation = "https://docs.rs/jkconfig"
edition = "2024"
keywords = ["tui", "config", "json-schema", "terminal"]
license = "MIT OR Apache-2.0"
name = "jkconfig"
readme = "README.md"
repository = "https://github.com/ZR233/ostool"
repository = "https://github.com/drivercraft/ostool"
version = "0.1.5"

[[bin]]
Expand Down
3 changes: 1 addition & 2 deletions ostool/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
authors = ["周睿 <zrufo747@outlook.com>"]
categories = ["command-line-utilities", "embedded", "development-tools"]
description = "A tool for operating system development"
documentation = "https://docs.rs/ostool"
edition = "2024"
keywords = ["os", "embedded", "qemu", "u-boot", "bootloader"]
license = "MIT OR Apache-2.0"
name = "ostool"
readme = "../README.md"
repository = "https://github.com/ZR233/ostool"
repository = "https://github.com/drivercraft/ostool"
version = "0.8.9"

[package.metadata.binstall]
Expand Down
4 changes: 1 addition & 3 deletions uboot-shell/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
authors = ["周睿 <zrufo747@outlook.com>"]
categories = ["os", "embedded", "development-tools"]
description = "A crate for communicating with u-boot"
documentation = "https://docs.rs/uboot-shell"
edition = "2024"
keywords = ["u-boot", "shell", "embedded", "serial", "ymodem"]
license = "MIT"
name = "uboot-shell"
readme = "README.md"
repository = "https://github.com/ZR233/ostool"
repository = "https://github.com/drivercraft/ostool"
version = "0.2.1"

[dependencies]
Expand Down