Keep package:meta import for Flutter <3.35#279
Merged
Conversation
Keep the explicit `package:meta` import for backward compatibility with Flutter versions older than 3.35.0, where the `@internal` annotation is provided by the `meta` package. Suppress the analyzer `unnecessary_import` warning on newer SDKs that re-export `@internal` from `package:flutter/foundation.dart`. Refs: flutter/flutter@5706259
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds backward compatibility for the @internal annotation by keeping the explicit package:meta import and suppressing the unnecessary_import analyzer warning for Flutter SDKs >= 3.35.0.
- Adds explanatory comments describing why the
package:metaimport is retained - Suppresses the
unnecessary_importanalyzer warning using// ignore:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the explicit
package:metaimport for backward compatibility with Flutter versions older than 3.35.0, where the@internalannotation is provided by themetapackage. Suppress the analyzerunnecessary_importwarning on newer SDKs that re-export@internalfrompackage:flutter/foundation.dart.