Add gradle-wrapper.properties and set Gradle to 8.13#280
Merged
Conversation
Add `gradle-wrapper.properties` to the example Android projects and set `distributionUrl` to `https://services.gradle.org/distributions/gradle-8.13-bin.zip` to fix build failures when building the example with recent Flutter toolchains. Reason: Newer Flutter versions (3.22/3.27+ and above) use Kotlin APIs (e.g. `filePermissions`) that require Gradle 8.3+. Old Gradle wrappers cause Kotlin unresolved reference errors during the example's Android build. See flutter/flutter#176467 (comment) for details.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes Gradle wrapper configuration across both example projects by adding gradle-wrapper.properties files that specify Gradle 8.13, and refines .gitignore patterns to better manage Gradle-related files. The changes allow the Gradle wrapper properties to be version controlled while ignoring the wrapper binaries and generated artifacts.
Key Changes
- Added
gradle-wrapper.propertiesfiles specifying Gradle 8.13 in both example Android projects - Updated
.gitignorepatterns to selectively ignore Gradle wrapper executables and JAR files while allowing properties to be tracked - Consolidated and modernized
.gitignorepatterns for Gradle artifacts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
flutter_custom_tabs_android/example/android/gradle/wrapper/gradle-wrapper.properties |
Added Gradle 8.13 wrapper configuration with standard distribution settings |
flutter_custom_tabs_android/example/android/.gitignore |
Refined Gradle ignore patterns to allow wrapper properties while ignoring executables; however, the /build pattern was inadvertently removed |
flutter_custom_tabs/example/android/gradle/wrapper/gradle-wrapper.properties |
Added Gradle 8.13 wrapper configuration with standard distribution settings |
flutter_custom_tabs/example/android/.gitignore |
Refined Gradle ignore patterns to allow wrapper properties while ignoring executables; however, the /build pattern was inadvertently removed |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates Gradle configuration and related
.gitignorerules for the Android example projects in bothflutter_custom_tabsandflutter_custom_tabs_android. The main changes focus on standardizing Gradle wrapper usage and improving the.gitignorepatterns to better handle Gradle and build artifacts.Gradle configuration updates:
gradle-wrapper.propertiesfile specifying Gradle 8.13 and standard wrapper settings in bothflutter_custom_tabs/example/android/gradle/wrapper/andflutter_custom_tabs_android/example/android/gradle/wrapper/..gitignore improvements:
.gitignorefiles in bothflutter_custom_tabs/example/android/andflutter_custom_tabs_android/example/android/to ignore Gradle wrapper files and directories more precisely, including**/gradle-wrapper.jar,.gradle/,.cxx/,gradlew, andgradlew.bat, while removing outdated or redundant patterns.